Skip to content

Commit

Permalink
net/core: remove explicit do_softirq() from busy_poll_stop()
Browse files Browse the repository at this point in the history
Since commit 217f697 ("net: busy-poll: allow preemption in
sk_busy_loop()") there is an explicit do_softirq() invocation after
local_bh_enable() has been invoked.
I don't understand why we need this because local_bh_enable() will
invoke do_softirq() once the softirq counter reached zero and we have
softirq-related work pending.

Signed-off-by: Sebastian Andrzej Siewior <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Sebastian Siewior authored and davem330 committed Jun 20, 2017
1 parent bdaf32c commit fe420d8
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/core/dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -5206,8 +5206,6 @@ static void busy_poll_stop(struct napi_struct *napi, void *have_poll_lock)
if (rc == BUSY_POLL_BUDGET)
__napi_schedule(napi);
local_bh_enable();
if (local_softirq_pending())
do_softirq();
}

void napi_busy_loop(unsigned int napi_id,
Expand Down

0 comments on commit fe420d8

Please sign in to comment.