Add explanatory note for class_eval

amcaplan · Jan 31, 2016 · 011c862 · 011c862
1 parent 3984161
commit 011c862
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/lib/dynamic_class.rb b/lib/dynamic_class.rb
@@ -94,6 +94,14 @@ def hash
     def add_methods!(key)
       self.class.send(:attr_accessor, key)
       self.class.attributes << key
+
+      # I'm pretty sure this is safe, because attempting to add an attribute
+      # that isn't a valid instance variable name will raise an error. Please
+      # contact the maintainer if you find a situation where this could be a
+      # security problem.
+      #
+      # The reason to use class_eval here is because, based on benchmarking,
+      # this defines the fastest version of #to_h possible.
       self.class.class_eval <<-RUBY
         def to_h
           {