Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding rocprofiler-systems jacobi README based on Omnitrace #93

Merged
merged 2 commits into from
Mar 4, 2025
Merged

adding rocprofiler-systems jacobi README based on Omnitrace #93

merged 2 commits into from
Mar 4, 2025

Conversation

lstanisi-amd
Copy link
Collaborator

Please check if you are fine with the new README, especially regarding the names

gsitaram
gsitaram approved these changes Feb 28, 2025
View reviewed changes
Copy link
Collaborator

@gsitaram gsitaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided some feedback. After comments are addressed, I approve.

@lstanisi-amd
Copy link
Collaborator Author

addressed all Gina's suggestions

@gcapodagAMD gcapodagAMD merged commit 8484627 into main Mar 4, 2025
@gcapodagAMD
Copy link
Collaborator

thanks @gsitaram and @lstanisi-amd

@lstanisi-amd lstanisi-amd deleted the rocprof-sys_jacobi_readme branch March 4, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gsitaram gsitaram gsitaram approved these changes

@gcapodagAMD gcapodagAMD Awaiting requested review from gcapodagAMD

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lstanisi-amd @gcapodagAMD @gsitaram