Build config-rs for configuration management #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As said in previous PR's, the commit message seems too lengthy. Please shorten it, including the PR name. Check this guide : PR Naming Guide Also, rebase your branch on top of develop, resolve conflicts, and push the updated branch. |
|
I'll update the name of the PR and the commit message and resolve conflicts |
Harshith-2208
changed the title
|
Done with rebase and resolving conflicts and also shortened commit message as well as PR title |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30
I have added a config.toml which stores all the ids and url then updated cargo.toml by adding two dependencies. Then a config.rs to handle all configurations and included config.rs in main.rs. Then replaced the occurrence of hard coded values with CONFIG like
GROUP_ONE_CHANNEL_IDtoCONFIG.channels.group_one.Then deleted the file ids.rs which was of no use anymore.