Skip to content

Commit

Permalink
[LTP] Remove GRAMINE_LTP_LIVE_OUTPUT
Browse files Browse the repository at this point in the history
Since the output shown after a test failure now contains timestamps,
there is no point to showing the logs of specific tests live.

This reverts the relevant part of the commit "[LTP] Run timeout-prone
tests with unbufferred output".

Signed-off-by: Jakub Kądziołka <[email protected]>
  • Loading branch information
meithecatte authored and Dmitrii Kuvaiskii committed Jul 1, 2022
1 parent d92a7f1 commit 918fd0d
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 8 deletions.
1 change: 0 additions & 1 deletion .ci/lib/stage-test-direct.jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ stage('test-direct') {
// separately
sh '''
cd libos/test/ltp
export GRAMINE_LTP_LIVE_OUTPUT=fcntl14,fdatasync01
python3 -m pytest -v -n4 --junit-xml=ltp.xml
'''
}
Expand Down
9 changes: 2 additions & 7 deletions libos/test/ltp/test_ltp.py
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def check_must_pass(passed, failed, must_pass):
pytest.fail('All subtests skipped, replace must-pass with skip')


def test_ltp(cmd, section, capsys):
def test_ltp(cmd, section):
must_pass = section.getintset('must-pass')

loader = 'gramine-sgx' if HAS_SGX else 'gramine-direct'
Expand All @@ -193,12 +193,7 @@ def test_ltp(cmd, section, capsys):
logging.info('command: %s', full_cmd)
logging.info('must_pass: %s', list(must_pass) if must_pass else 'all')

live_output = os.getenv('GRAMINE_LTP_LIVE_OUTPUT') or ''
if section.name in live_output.split(','):
with capsys.disabled():
returncode, stdout, _stderr = run_command(full_cmd, timeout=timeout, can_fail=True)
else:
returncode, stdout, _stderr = run_command(full_cmd, timeout=timeout, can_fail=True)
returncode, stdout, _stderr = run_command(full_cmd, timeout=timeout, can_fail=True)

# Parse output regardless of whether `must_pass` is specified: unfortunately some tests
# do not exit with non-zero code when failing, because they rely on `MAP_SHARED` (which
Expand Down

0 comments on commit 918fd0d

Please sign in to comment.