Skip to content

Commit

Permalink
Fix an ASAN error in transaction_test.cc
Browse files Browse the repository at this point in the history
Summary:
One test in transaction_test.cc forgets to call SyncPoint::DisableProcessing().
As a result, a program might to access the SyncPoint singleton after it
already goes out of scope.

This patch fix this error by calling SyncPoint::DisableProcessing().

Test Plan: transaction_test

Reviewers: sdong, IslamAbdelRahman, kradhakrishnan, anthony

Reviewed By: anthony

Subscribers: dhruba, leveldb

Differential Revision: https://reviews.facebook.net/D54033
  • Loading branch information
yhchiang committed Feb 10, 2016
1 parent 2a04268 commit 3a67bff
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions utilities/transactions/transaction_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -2876,6 +2876,7 @@ TEST_F(TransactionTest, ExpiredTransactionDataRace1) {
ASSERT_EQ("1", value);

delete txn1;
rocksdb::SyncPoint::GetInstance()->DisableProcessing();
}

} // namespace rocksdb
Expand Down

0 comments on commit 3a67bff

Please sign in to comment.