Merge pull request roo-rb#297 from stevendaniels/allow_streaming_for_csv

Allow streaming for Roo::CSV
amrdruid · Feb 9, 2016 · 6aa6a73 · 6aa6a73
2 parents d348264 + 67fda22
commit 6aa6a73
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/lib/roo/csv.rb b/lib/roo/csv.rb
@@ -60,6 +60,8 @@ def each_row(options, &block)
         tmp_filename = download_uri(filename, tmpdir)
         CSV.foreach(tmp_filename, options, &block)
       end
+    elsif is_stream?(filename_or_stream)
+      CSV.new(filename_or_stream, options).each(&block)
     else
       CSV.foreach(filename, options, &block)
     end
@@ -117,4 +119,6 @@ def clean_sheet(sheet)
 
     @cleaned[sheet] = true
   end
+
+  alias_method :filename_or_stream, :filename
 end
diff --git a/spec/lib/roo/csv_spec.rb b/spec/lib/roo/csv_spec.rb
@@ -10,6 +10,13 @@
     end
   end
 
+  describe '.new with stream' do
+    let(:csv) { Roo::CSV.new(File.read(path)) }
+    it 'creates an instance' do
+      expect(csv).to be_a(Roo::CSV)
+    end
+  end
+
   describe '#parse' do
     subject do
       csv.parse(options)