Skip to content

Commit

Permalink
Changing a DCHECK to a CHECK in order to catch this error in release …
Browse files Browse the repository at this point in the history
…builds.

I managed to hit this problem locally by following reproduction steps in
bug 335031. My guess is that this might be causing data corruption and
several so-far unexplained crashes, so I think that a reasonable first step
is to upgrade the DCHECK to a CHECK.

Committing as TBR to get this in asap.

BUG=335031
[email protected]
NOTRY=True

Review URL: https://codereview.chromium.org/143443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@246036 0039d316-1c4b-4281-b951-d872f2087c98
  • Loading branch information
[email protected] committed Jan 21, 2014
1 parent f6972de commit 88ecb5f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ipc/ipc_channel_win.cc
Original file line number Diff line number Diff line change
Expand Up @@ -372,7 +372,7 @@ bool Channel::ChannelImpl::ProcessOutgoingMessages(
return false;
}
// Message was sent.
DCHECK(!output_queue_.empty());
CHECK(!output_queue_.empty());
Message* m = output_queue_.front();
output_queue_.pop();
delete m;
Expand Down

0 comments on commit 88ecb5f

Please sign in to comment.