Only sync published releases.

The current code fails if a repository contains unpublished/ draft releases due to a missing publish date.
amzn · Sep 13, 2018 · 2793463 · 2793463
1 parent bc6138d
commit 2793463
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 15 deletions.
diff --git a/github-sync-tng/release_command.rb b/github-sync-tng/release_command.rb
@@ -80,14 +80,16 @@ def db_insert_releases(db, org, repo, releases)
               end
           end
 
-
-          db[
-           "INSERT INTO releases (
-              org, repo, id, html_url, tarball_url, zipball_url, tag_name, name, body, created_at, published_at, author
-            )
-            VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )",
-            org, repo, release.id, release.html_url, release.tarball_url, release.zipball_url, release.tag_name, release.name, release.body, release.created_at.to_s,
-            release.published_at.to_s, author].insert
+	  # only include releases that were published
+	  if(release.published_at)
+	          db[
+        	   "INSERT INTO releases (
+	              org, repo, id, html_url, tarball_url, zipball_url, tag_name, name, body, created_at, published_at, author
+	            )
+	            VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )",
+	            org, repo, release.id, release.html_url, release.tarball_url, release.zipball_url, release.tag_name, release.name, release.body, release.created_at.to_s,
+	            release.published_at.to_s, author].insert
+	  end
       end
     end
   end

diff --git a/github-sync/db_releases/sync-releases.rb b/github-sync/db_releases/sync-releases.rb
@@ -35,13 +35,16 @@ def db_insert_releases(db, org, repo, releases)
           end
       end
 
-      db[
-       "INSERT INTO releases (
-          org, repo, id, html_url, tarball_url, zipball_url, tag_name, name, body, created_at, published_at, author
-        )
-        VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )",
-        org, repo, release.id, release.html_url, release.tarball_url, release.zipball_url, release.tag_name,
-        release.name, release.body, release.created_at.to_s, release.published_at.to_s, author].insert
+      # only track published releases
+      if(release.published_at)
+	db[
+          "INSERT INTO releases (
+            org, repo, id, html_url, tarball_url, zipball_url, tag_name, name, body, created_at, published_at, author
+          )
+          VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )",
+          org, repo, release.id, release.html_url, release.tarball_url, release.zipball_url, release.tag_name,
+          release.name, release.body, release.created_at.to_s, release.published_at.to_s, author].insert
+      end
   end
 end