Fix masked_fill no-op (facebookresearch#3068)

Issue with using the out-of-place version of .masked_fill()
analysmith · Sep 10, 2020 · 84351e5 · 84351e5
1 parent 5265587
commit 84351e5
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/parlai/agents/transformer/modules.py b/parlai/agents/transformer/modules.py
@@ -1258,7 +1258,7 @@ def forward(self, xs, ys, mask_ys=None, values=None):
         if mask_ys is not None:
             attn_mask = (mask_ys == 0).view(bsz, 1, y_len)
             attn_mask = attn_mask.repeat(1, x_len, 1)
-            l1.masked_fill(attn_mask, neginf(l1.dtype))
+            l1.masked_fill_(attn_mask, neginf(l1.dtype))
         l2 = F.softmax(l1, dim=self.dim, dtype=torch.float).type_as(l1)
         if values is None:
             values = ys