opts: fix potential integer overflow CWE-190, CWE-681

Caught by CodeQL: > Incorrect conversion of an integer with architecture-dependent bit size > from strconv.ParseUint to a lower bit size type uint16 without an upper > bound check. fixes https://github.com/docker/cli/security/code-scanning/2 Signed-off-by: Sebastiaan van Stijn <[email protected]>
anamehra · Oct 23, 2020 · 5cd19d1 · 5cd19d1
1 parent 0641480
commit 5cd19d1
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/opts/weightdevice.go b/opts/weightdevice.go
@@ -20,7 +20,7 @@ func ValidateWeightDevice(val string) (*blkiodev.WeightDevice, error) {
 	if !strings.HasPrefix(split[0], "/dev/") {
 		return nil, fmt.Errorf("bad format for device path: %s", val)
 	}
-	weight, err := strconv.ParseUint(split[1], 10, 0)
+	weight, err := strconv.ParseUint(split[1], 10, 16)
 	if err != nil {
 		return nil, fmt.Errorf("invalid weight for device: %s", val)
 	}