Fixes cucumber-attic#175. PrettyFormatter should not modify table, bu…

…t safely work with it instead
anay · Apr 4, 2013 · 7e7ed34 · 7e7ed34
1 parent 279b083
commit 7e7ed34
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 13 deletions.
diff --git a/java/src/main/java/gherkin/formatter/PrettyFormatter.java b/java/src/main/java/gherkin/formatter/PrettyFormatter.java
@@ -282,7 +282,7 @@ public void table(List<? extends Row> rows) {
 
     private void prepareTable(List<? extends Row> rows) {
         this.rows = rows;
-        
+
         // find the largest row
         int columnCount = 0;
         for (Row row : rows) {
@@ -295,22 +295,21 @@ private void prepareTable(List<? extends Row> rows) {
         maxLengths = new int[columnCount];
         for (int rowIndex = 0; rowIndex < rows.size(); rowIndex++) {
             Row row = rows.get(rowIndex);
-            List<String> cells = row.getCells();
+            final List<String> cells = row.getCells();
             for (int colIndex = 0; colIndex < columnCount; colIndex++) {
-
-                // check missing cells
-                if (colIndex >= cells.size()) {
-                    cells.add("");
-                }
-                String cell = cells.get(colIndex);                
-                int length = escapeCell(cell).length();
+                final String cell = getCellSafely(cells, colIndex);
+                final int length = escapeCell(cell).length();
                 cellLengths[rowIndex][colIndex] = length;
                 maxLengths[colIndex] = Math.max(maxLengths[colIndex], length);
             }
         }
         rowIndex = 0;
     }
 
+    private String getCellSafely(final List<String> cells, final int colIndex) {
+        return (colIndex < cells.size()) ? cells.get(colIndex) : "";
+    }
+
     public void row(List<CellResult> cellResults) {
         Row row = rows.get(rowIndex);
         if (rowsAbove) {
@@ -337,11 +336,11 @@ public void row(List<CellResult> cellResults) {
                 break;
         }
         for (int colIndex = 0; colIndex < maxLengths.length; colIndex++) {
-            String cellText = escapeCell(row.getCells().get(colIndex));
+            String cellText = escapeCell(getCellSafely(row.getCells(), colIndex));
             String status = null;
             switch (row.getDiffType()) {
                 case NONE:
-                    status = cellResults.get(colIndex).getStatus();
+                    status = cellResults.size() < colIndex ? cellResults.get(colIndex).getStatus() : "skipped";
                     break;
                 case DELETE:
                     status = "skipped";
@@ -471,4 +470,4 @@ private static String indent(String s, String indentation) {
     private static String escapeTripleQuotes(String s) {
         return TRIPLE_QUOTES.matcher(s).replaceAll(ESCAPED_TRIPLE_QUOTES);
     }
-}
+}
diff --git a/java/src/test/java/gherkin/formatter/PrettyFormatterTest.java b/java/src/test/java/gherkin/formatter/PrettyFormatterTest.java
@@ -171,5 +171,5 @@ private List<String> doFormatter(String feature) throws IOException {
         return lines;
 
     }
-    
+
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -171,5 +171,5 @@ private List<String> doFormatter(String feature) throws IOException {
		return lines;

		}


		}