remove "Tour" functionality. nothing used it.

closes: CNVS-28669 refs: CNVS-28781 Back in 2013 we came up with an awesome idea to have these "Tours" to introduce new features and stuff. It was a great idea but we don't use it anymore. it has been commented out so it doesn't show up in the styleguide and all but one (see below) were commented out of config/tours.rb. so in the interest of not letting code hang around that we don't use, I'm removing it (unless anyone is opposed or has a good reason to leave it). If we want to do it in the future, we can just add it back, because yay Git! There was one place in quizzes that was still trying to use a tour. if you go to create a quiz and edit a question and then pick another option as the correct answer for a multiple choice question it would try to show a tour telling you that you could regrade all the existing submissions. but in reality it just threw a javascript error and the tour never popped up. So even though it was still in the code, it didn't work. Since no one noticed that it stopped working, I'm assuming we don't need it any more. Quizzes team and quizzes product/QA, will you confirm this is ok? test plan: * no tours should show up anywhere in canvas * read that paragraph above about the "regrade existing" thing in quizzes. * try that feature, it should work but no tour should show up and no error should occur in the console Change-Id: Ib2d6bbb80f93fd7ca0a33d20c1f57ee16e7027ea Reviewed-on: https://gerrit.instructure.com/76875 Tested-by: Jenkins Reviewed-by: Jennifer Stern <[email protected]> QA-Review: Michael Hargiss <[email protected]> Product-Review: Ryan Shaw <[email protected]>
anaymalpani · Apr 21, 2016 · 80a7fb0 · 80a7fb0
1 parent 2876c58
commit 80a7fb0
Show file tree

Hide file tree

Showing 28 changed files with 1 addition and 1,580 deletions.
diff --git a/.fontcustom-manifest.json b/.fontcustom-manifest.json
@@ -678,14 +678,6 @@
       "codepoint": 61853,
       "source": "public/fonts/icons/toggle-right.svg"
     },
-    "tour-info": {
-      "codepoint": 61854,
-      "source": "public/fonts/icons/tour-info.svg"
-    },
-    "tour-step-counter": {
-      "codepoint": 61855,
-      "source": "public/fonts/icons/tour-step-counter.svg"
-    },
     "trash": {
       "codepoint": 61856,
       "source": "public/fonts/icons/trash.svg"

diff --git a/app/coffeescripts/bundles/common.coffee b/app/coffeescripts/bundles/common.coffee
@@ -5,7 +5,6 @@ require [
   # true modules that we manage in this file
   'Backbone'
   'compiled/helpDialog'
-  'compiled/tours'
 
   # modules that do their own thing on every page that simply need to
   # be required
@@ -47,9 +46,8 @@ require [
   'vendor/jquery.pageless'
   'vendor/jquery.scrollTo'
   'compiled/badge_counts'
-], ($, _, Backbone, helpDialog, tours) ->
+], ($, _, Backbone, helpDialog) ->
   helpDialog.initTriggers()
-  tours.init()
 
   $('#skip_navigation_link').on 'click', ->
     $($(this).attr('href')).attr('tabindex', -1).focus()

diff --git a/app/coffeescripts/tours.coffee b/app/coffeescripts/tours.coffee
diff --git a/app/coffeescripts/views/TourView.coffee b/app/coffeescripts/views/TourView.coffee
diff --git a/app/coffeescripts/views/tours/AgendaTour.coffee b/app/coffeescripts/views/tours/AgendaTour.coffee
diff --git a/app/coffeescripts/views/tours/QuizRegrade.coffee b/app/coffeescripts/views/tours/QuizRegrade.coffee
diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
@@ -63,8 +63,6 @@ class ApplicationController < ActionController::Base
   before_filter :init_body_classes
   after_filter :set_response_headers
   after_filter :update_enrollment_last_activity_at
-  after_filter :teardown_live_events_context
-  include Tour
 
   add_crumb(proc {
     title = I18n.t('links.dashboard', 'My Dashboard')
@@ -129,8 +127,6 @@ def js_env(hash = {})
       @js_env[:TIMEZONE] = Time.zone.tzinfo.identifier if !@js_env[:TIMEZONE]
       @js_env[:CONTEXT_TIMEZONE] = @context.time_zone.tzinfo.identifier if !@js_env[:CONTEXT_TIMEZONE] && @context.respond_to?(:time_zone) && @context.time_zone.present?
       @js_env[:LOCALE] = I18n.qualified_locale if !@js_env[:LOCALE]
-      @js_env[:TOURS] = tours_to_run
-
       @js_env[:lolcalize] = true if ENV['LOLCALIZE']
     end
 

diff --git a/app/controllers/tours_controller.rb b/app/controllers/tours_controller.rb
diff --git a/app/stylesheets/components/_canvas-icons.scss b/app/stylesheets/components/_canvas-icons.scss
@@ -297,7 +297,6 @@ Either use `<a>` with icon desired icon class added or insert `<i>` inside `<but
   <span class="span3"><i class="icon-files-fair-use"></i> icon-files-fair-use</span>
   <span class="span3"><i class="icon-files-obtained-permission"></i>icon-files-obtained-permission</span>
   <span class="span3"><i class="icon-files-public-domain"></i> icon-files-public-domain</span>
-  <span class="span3"><i class="icon-tour-info"></i> icon-tour-info</span>
 </div>
 <div class="row-fluid">
   <span class="span3"><i class="icon-import"></i> icon-import</span>
@@ -569,8 +568,6 @@ h1, h2, h3, h4, .h1, .h2, .h3, .h4, p {
 .icon-timer:before { content: "\f19b"; }
 .icon-toggle-left:before { content: "\f19c"; }
 .icon-toggle-right:before { content: "\f19d"; }
-.icon-tour-info:before { content: "\f19e"; }
-.icon-tour-step-counter:before { content: "\f19f"; }
 .icon-trash:before { content: "\f1a0"; }
 .icon-trouble:before { content: "\f1a1"; }
 .icon-twitter:before { content: "\f1a2"; }

diff --git a/app/stylesheets/components/_main.scss b/app/stylesheets/components/_main.scss
@@ -31,7 +31,6 @@
 @import "post-to-sis-state";
 @import "pill";
 @import "alerts";
-@import "tour-popovers";
 @import "element-toggler";
 @import "ic-super-toggle";
 @import "ic-image-text-combo";