Fix for sudo defaults if sudo is passed in via --extra-vars

andelf · Oct 27, 2012 · a768e9a · a768e9a
1 parent 7d7ff9d
commit a768e9a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/lib/ansible/playbook/task.py b/lib/ansible/playbook/task.py
@@ -68,8 +68,9 @@ def __init__(self, play, ds, module_vars=None):
         self.name         = ds.get('name', None)
         self.tags         = [ 'all' ]
         self.register     = ds.get('register', None)
-        self.sudo         = ds.get('sudo', play.sudo)
-        if self.sudo is True:
+        self.sudo         = utils.boolean(ds.get('sudo', play.sudo))
+
+        if self.sudo:
             self.sudo_user    = ds.get('sudo_user', play.sudo_user)
             self.sudo_pass    = ds.get('sudo_pass', play.playbook.sudo_pass)
         else:

diff --git a/lib/ansible/utils.py b/lib/ansible/utils.py
@@ -499,3 +499,12 @@ def get_available_modules(dirname=None):
             modules_list.update(os.listdir(path))
     modules_list = list(modules_list)
     return modules_list
+
+def boolean(value):
+    val = str(value)
+    if val.lower() in [ "true", "t", "y", "1", "yes" ]:
+        return True
+    else:
+        return False
+
+