Skip to content

Commit

Permalink
Do not run RateLimiterTest.Rate test on Travis+Mac OSX.
Browse files Browse the repository at this point in the history
Summary:
RateLimiterTest.Rate test has been failing continuously since many days on travis in Mac OSX PLATFORM_DEPENDENT test suite.
Check https://travis-ci.org/facebook/rocksdb/pull_requests.

Disabling this test for now, so that we can investigate more in depth.
Closes facebook#2451

Differential Revision: D5250147

Pulled By: sagar0

fbshipit-source-id: d58476a3c2792d20e875754d1516c4bc7174e86c
  • Loading branch information
sagar0 authored and facebook-github-bot committed Jun 14, 2017
1 parent ae8571f commit 53dda87
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions util/rate_limiter_test.cc
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ TEST_F(RateLimiterTest, Modes) {
}
}

#if !(defined(TRAVIS) && defined(OS_MACOSX))
TEST_F(RateLimiterTest, Rate) {
auto* env = Env::Default();
struct Arg {
Expand Down Expand Up @@ -121,6 +122,7 @@ TEST_F(RateLimiterTest, Rate) {
}
}
}
#endif

TEST_F(RateLimiterTest, LimitChangeTest) {
// starvation test when limit changes to a smaller value
Expand Down

0 comments on commit 53dda87

Please sign in to comment.