Skip to content

Commit

Permalink
Fix warnings while generating RocksJava documentation
Browse files Browse the repository at this point in the history
Summary:
There are a couple of warnings while building RocksJava, coming from Javadoc generation.
```
Generating target/apidocs/org/rocksdb/RocksDB.html...
src/main/java/org/rocksdb/RocksDB.java:2139: warning: no throws for org.rocksdb.RocksDBException
  public void ingestExternalFile(final List<String> filePathList,
              ^
src/main/java/org/rocksdb/RocksDB.java:2162: warning: no throws for org.rocksdb.RocksDBException
  public void ingestExternalFile(final ColumnFamilyHandle columnFamilyHandle,
              ^
```
Closes facebook#2396

Differential Revision: D5178388

Pulled By: sagar0

fbshipit-source-id: a0ab6696d6de78d089a9a860a559f64cc320019e
  • Loading branch information
sagar0 authored and facebook-github-bot committed Jun 5, 2017
1 parent 52a7f38 commit b172a3f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions java/src/main/java/org/rocksdb/RocksDB.java
Original file line number Diff line number Diff line change
Expand Up @@ -2135,6 +2135,9 @@ private long[] toNativeHandleList(final List<? extends RocksObject> objectList)
*
* @param filePathList The list of files to ingest
* @param ingestExternalFileOptions the options for the ingestion
*
* @throws RocksDBException thrown if error happens in underlying
* native library.
*/
public void ingestExternalFile(final List<String> filePathList,
final IngestExternalFileOptions ingestExternalFileOptions)
Expand All @@ -2158,6 +2161,9 @@ public void ingestExternalFile(final List<String> filePathList,
* @param columnFamilyHandle The column family for the ingested files
* @param filePathList The list of files to ingest
* @param ingestExternalFileOptions the options for the ingestion
*
* @throws RocksDBException thrown if error happens in underlying
* native library.
*/
public void ingestExternalFile(final ColumnFamilyHandle columnFamilyHandle,
final List<String> filePathList,
Expand Down

0 comments on commit b172a3f

Please sign in to comment.