New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upload Signature fix containing Redirect Url #1

Open

MindyContractor wants to merge 2 commits into andheiberg:master from MindyContractor:master

+17 −1

MindyContractor commented Sep 2, 2014

No description provided.

Designer Developer 2 added 2 commits

September 2, 2014 14:18


          Upload Signature fix - redirect Url should not be URL encoded

0665d41


          Updated composer file

Owner

andheiberg commented Sep 9, 2014

Okay I haven't used Vzaar in a while, but your changes would break a lot of use cases, so I won't merge it as is.

So first of all you can't change the package name in composer. Adding your self to authors is questionable, but I would allow it.

Secondly by not url encoding any of the url parameters you are potentially creating a lot of issues.

I figure there is some bug you are trying to fix? What is it exactly?

Why should it not be url encoded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet