Skip to content

Commit

Permalink
xml: Use the correct QString::arg() overload
Browse files Browse the repository at this point in the history
arg(const QString &a, int fieldWidth, QChar fillChar) was being called
and that's not what we want.

Found with clazy static analyzer

Change-Id: Ia5051bb2f979af496038c66580d199262b6cfa8b
Reviewed-by: Marc Mutz <[email protected]>
Reviewed-by: Mitch Curtis <[email protected]>
  • Loading branch information
iamsergio committed Oct 8, 2015
1 parent 363498e commit a41cd12
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/xml/sax/qxml.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6457,7 +6457,7 @@ bool QXmlSimpleReaderPrivate::isExpandedEntityValueTooLarge(QString *errorMessag
if (*expandedIt > entityCharacterLimit) {
if (errorMessage) {
*errorMessage = QString::fromLatin1("The XML entity \"%1\" expands to a string that is too large to process (%2 characters > %3).")
.arg(entity, *expandedIt, entityCharacterLimit);
.arg(entity, QString::number(*expandedIt), QString::number(entityCharacterLimit));
}
return true;
}
Expand Down

0 comments on commit a41cd12

Please sign in to comment.