move to lila.web.SocketTest, add distribution live setting

app/Env.scala

@@ -143,7 +143,6 @@ given ConfigLoader[NetConfig] = ConfigLoader(config =>
       siteName = get[String]("site.name"),
       socketDomains = get[List[String]]("socket.domains"),
       socketAlts = get[List[String]]("socket.alts"),
-      socketTest = get[Boolean]("socket.test"),
       crawlable = get[Boolean]("crawlable"),
       rateLimit = get[RateLimit]("ratelimit"),
       email = get[EmailAddress]("email"),

app/UiEnv.scala

@@ -25,6 +25,7 @@ object UiEnv
   def netConfig           = env.net
   def contactEmailInClear = env.net.email.value
   def picfitUrl           = env.memo.picfitUrl
+  def socketTest          = env.web.socketTest
 
   given lila.core.config.NetDomain                           = env.net.domain
   given (using ctx: PageContext): Option[Nonce]              = ctx.nonce

app/controllers/Dev.scala

@@ -27,6 +27,7 @@ final class Dev(env: Env) extends LilaController(env):
     env.web.settings.noDelaySecret,
     env.web.settings.prizeTournamentMakers,
     env.web.settings.sitewideCoepCredentiallessHeader,
+    env.web.socketTest.distributionSetting,
     env.tournament.reloadEndpointSetting,
     env.tutor.nbAnalysisSetting,
     env.tutor.parallelismSetting,
@@ -84,7 +85,7 @@ final class Dev(env: Env) extends LilaController(env):
       .fold(
         err => BadRequest(Json.obj("error" -> err.toString)),
         results =>
-          env.api.socketTestResult
+          env.web.socketTest
             .put(Json.obj(me.userId.toString -> results))
             .inject(jsonOkResult)
       )

app/views/base/page.scala

@@ -4,7 +4,6 @@ import scalalib.StringUtils.escapeHtmlRaw
 import lila.app.UiEnv.{ *, given }
 import lila.common.String.html.safeJsonValue
 import lila.ui.RenderedPage
-import lila.api.SocketTest
 
 object page:
 
@@ -114,9 +113,9 @@ object page:
             .option(env.push.vapidPublicKey),
           dataUser                         := ctx.userId,
           dataSoundSet                     := pref.currentSoundSet.toString,
-          attr("data-socket-domains")      := SocketTest.socketEndpoints(netConfig).mkString(","),
-          attr("data-socket-test-user")    := SocketTest.isUserInTestBucket(netConfig),
-          attr("data-socket-test-running") := netConfig.socketTest,
+          attr("data-socket-domains")      := socketTest.socketEndpoints(netConfig).mkString(","),
+          attr("data-socket-test-user")    := socketTest.isUserInTestBucket(),
+          attr("data-socket-test-running") := socketTest.isTestRunning(),
           dataAssetUrl,
           dataAssetVersion := assetVersion,
           dataNonce        := ctx.nonce.ifTrue(sameAssetDomain).map(_.value),

conf/base.conf

@@ -15,7 +15,6 @@ net {
   domain = "localhost:9663"
   socket.domains = ["localhost:9664"]
   socket.alts = []
-  socket.test = false
   asset.domain = ${net.domain}
   asset.base_url = "http://"${net.asset.domain}
   asset.base_url_internal = ${net.asset.base_url}

modules/api/src/main/Env.scala

@@ -2,7 +2,6 @@ package lila.api
 
 import akka.actor.*
 import com.softwaremill.macwire.*
-import com.softwaremill.tagging.*
 import play.api.Mode
 
 import lila.chat.{ GetLinkCheck, IsChatFresh }
@@ -59,8 +58,7 @@ final class Env(
     webConfig: lila.web.WebConfig,
     realPlayerApi: lila.web.RealPlayerApi,
     bookmarkExists: lila.core.bookmark.BookmarkExists,
-    manifest: lila.web.AssetManifest,
-    yoloDb: lila.db.AsyncDb @@ lila.db.YoloDb // for socket test results
+    manifest: lila.web.AssetManifest
 )(using val mode: Mode, scheduler: Scheduler)(using
     Executor,
     ActorSystem,
@@ -97,9 +95,6 @@ final class Env(
 
   lazy val cli = wire[Cli]
 
-  lazy val socketTestResult =
-    SocketTestResult(yoloDb(lila.core.config.CollName("socket_test")).failingSilently())
-
   private lazy val linkCheck = wire[LinkCheck]
   lazy val chatFreshness     = wire[ChatFreshness]
 

modules/core/src/main/config.scala

@@ -68,7 +68,6 @@ object config:
       siteName: String,
       socketDomains: List[String],
       socketAlts: List[String],
-      socketTest: Boolean,
       crawlable: Boolean,
       rateLimit: RateLimit,
       email: EmailAddress,

modules/core/src/main/pref.scala

@@ -18,6 +18,7 @@ trait Pref:
   val resizeHandle: Int
   val theme: String
   val pieceSet: String
+  val usingAltSocket: Option[Boolean]
 
   def hasKeyboardMove: Boolean
   def hasVoice: Boolean

modules/db/src/main/JSON.scala

@@ -6,7 +6,7 @@ import reactivemongo.api.bson.*
 object JSON:
 
   def bdoc(json: JsObject): BSONDocument =
-    BSONDocument(json.fields.map { case (k, v) => k -> bval(v) })
+    BSONDocument(json.fields.map { (k, v) => k -> bval(v) })
 
   def bval(json: JsValue): BSONValue = json match
     case JsString(value)  => BSONString(value)

modules/web/src/main/Env.scala

@@ -1,13 +1,15 @@
 package lila.web
 
 import com.softwaremill.macwire.*
+import com.softwaremill.tagging.*
 import play.api.libs.ws.StandaloneWSClient
 
 @Module
 final class Env(
     appConfig: play.api.Configuration,
     environment: play.api.Environment,
     cacheApi: lila.memo.CacheApi,
+    yoloDb: lila.db.AsyncDb @@ lila.db.YoloDb,
     settingStore: lila.memo.SettingStore.Builder,
     ws: StandaloneWSClient,
     net: lila.core.config.NetConfig
@@ -33,6 +35,11 @@ final class Env(
   if mode.isProd then scheduler.scheduleOnce(5 seconds)(influxEvent.start())
   private lazy val pagerDuty = wire[PagerDuty]
 
+  val socketTest = SocketTest(
+    yoloDb(lila.core.config.CollName("socket_test")).failingSilently(),
+    settingStore
+  )
+
   lila.common.Bus.subscribeFun("announce"):
     case lila.core.socket.Announce(msg, date, _) if msg.contains("will restart") =>
       pagerDuty.lilaRestart(date)

modules/web/src/main/SocketTest.scala

@@ -0,0 +1,35 @@
+package lila.web
+
+import play.api.libs.json.*
+
+import lila.db.JSON
+import lila.core.config.NetConfig
+import lila.ui.Context
+
+final class SocketTest(
+    resultsDb: lila.db.AsyncCollFailingSilently,
+    settingStore: lila.memo.SettingStore.Builder
+)(using Executor):
+
+  val distributionSetting = settingStore[Int](
+    "socketTestDistribution",
+    default = 0,
+    text = "Participates to socket test if userId.hashCode % distribution == 0".some
+  )
+
+  def put(results: JsObject) = resultsDb: coll =>
+    coll.insert.one(JSON.bdoc(results)).void
+
+  def isTestRunning() = distributionSetting.get() > 0
+
+  def isUserInTestBucket()(using ctx: Context) =
+    isTestRunning() &&
+      ctx.pref.usingAltSocket.isEmpty &&
+      ctx.userId.exists(_.value.hashCode % distributionSetting.get() == 0)
+
+  def socketEndpoints(net: NetConfig)(using ctx: Context): List[String] =
+    ctx.pref.usingAltSocket.match
+      case Some(true)                => net.socketAlts
+      case Some(false)               => net.socketDomains
+      case _ if isUserInTestBucket() => net.socketDomains.head :: net.socketAlts.headOption.toList
+      case _                         => net.socketDomains