Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for l-pane custom element #22

Merged
merged 7 commits into from
Jul 14, 2024
Merged

Add support for l-pane custom element #22

merged 7 commits into from
Jul 14, 2024

Conversation

andrewgryan
Copy link
Owner

@andrewgryan andrewgryan commented Jul 11, 2024

Adds <l-pane> HTML custom element that can be used to support Leaflet JS panes.

E.g. the proposed CSS and HTML in a full app will look like this:

CSS

/** Control z-index within Leaflet standard panes */
.leaflet-foo-pane {
   z-index: 650;
   pointer-events: none;
}

HTML

<l-map zoom="1" center="[45,15]">
    <l-tile-layer ...></l-tile-layer>
    <l-pane name="foo">
         <l-image-overlay>...</l-image-overlay>
    </l-pane>
</l-map>

@andrewgryan andrewgryan changed the title WIP Add support for l-pane custom element Add support for l-pane custom element Jul 12, 2024
@andrewgryan
Copy link
Owner Author

This establishes a nice pattern for custom panes and a test suite to make it easy to support all elements in the future

@andrewgryan andrewgryan merged commit 11fc14b into master Jul 14, 2024
2 checks passed
@andrewgryan andrewgryan deleted the feature/pane branch July 14, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant