Tags: andrico21/tools
Tags
gopls: update go.mod file for gopls/v0.7.4-pre.1 Change-Id: Ife4bdbe1b812b47e5968c9eae666eb4145cd2f53 Reviewed-on: https://go-review.googlesource.com/c/tools/+/370658 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Hyang-Ah Hana Kim <[email protected]>
internal/memoize: do not allow (*Generation).Acquire to fail The Acquire method is nearly instantaneous; it only potentially blocks on a small, constant sequence of cache misses, so there is no need to avoid blocking in it when a Context is cancelled. An early return when the passed-in Context is canceled was added in CL 242838 to avoid incrementing the Generation's WaitGroup after its destruction has begun; however, that early return also bypasses the WaitGroup accounting that blocks Destroy while the generation is still in use. Instead, we need the invariant that Acquire is not called in the first place after Destroy, which we can ensure by nilling out the View's snapshot when we begin destroying it. I was not able to reproduce golang/go#48774 locally, but I believe that this CL will fix it. (It may, however, expose other races or deadlocks that may have been masked by the early return, which we can then fix separately.) Fixes golang/go#48774 Change-Id: Iac36fceb06485f849da5ba0250b44b55f937c44b Reviewed-on: https://go-review.googlesource.com/c/tools/+/367675 Trust: Bryan C. Mills <[email protected]> Run-TryBot: Bryan C. Mills <[email protected]> gopls-CI: kokoro <[email protected]> Reviewed-by: Robert Findley <[email protected]> TryBot-Result: Go Bot <[email protected]>
internal/typeparams: hide go1.18 API usage behind a build constraint Temporarily hide usage of the new go/types API, so that we can safely tag x/[email protected] without risk of further breakage when these APIs change. Updates golang/go#48632 Change-Id: Idba02d09644622b3d973a684a76514c86eefa17f Reviewed-on: https://go-review.googlesource.com/c/tools/+/352854 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]>
gopls/api-diff: create api-diff command for gopls api This change adds a command that can be used to see the difference in API between two gopls versions. It prints out the changes in a way that can be copy-pasted into the release notes. Also, only run the copyright test with 1.18. I wanted to do this before to use filepath.WalkDir, but now it also doesn't work with generic syntax (it doesn't use packages.Load, so doesn't respect build tags). Fixes golang/go#46652 Change-Id: I3670e0289a8eeaca02f4dcd8f88f206796ed2462 Reviewed-on: https://go-review.googlesource.com/c/tools/+/327276 Trust: Rebecca Stambler <[email protected]> Run-TryBot: Rebecca Stambler <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Robert Findley <[email protected]>
PreviousNext