Widget preview updates #1541
Widget preview updates #1541
Conversation
|
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
| style = TextStyle( | ||
| fontSize = 12.sp, | ||
| fontWeight = FontWeight.Medium, | ||
| color = fgColor | ||
| ), |
There was a problem hiding this comment.
should this be getting the style from the theme itself?
There was a problem hiding this comment.
It does, fgColor is set to GlanceTheme.colors.onPrimaryContainer
There was a problem hiding this comment.
The whole TextStyle though I mean, fontSize, weight etc.
There was a problem hiding this comment.
Perhaps, but I feel like that refactor is outside of the scope of this PR. The goal was to add widget previews.
There was a problem hiding this comment.
Thinking more, yes it could, no I don't think we should.
We'd need to build a bunch of XML resources, and that's not the pattern we're tyring to demonstrate with Glance widgets. See : https://github.com/android/platform-samples/blob/main/samples/user-interface/appwidgets/src/main/java/com/example/platform/ui/appwidgets/glance/layout/collections/layout/ImageTextListLayout.kt#L383 for an example
...r/glancewidget/src/main/java/com/example/jetcaster/glancewidget/JetcasterAppWidgetPreview.kt
Show resolved
Hide resolved
|
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
| @@ -147,6 +148,7 @@ kotlinx-collections-immutable = { module = "org.jetbrains.kotlinx:kotlinx-collec | |||
| kotlinx-coroutines-android = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-android", version.ref = "coroutines" } | |||
| kotlinx-coroutines-test = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-test", version.ref = "coroutines" } | |||
| kotlinx-serialization-json = { module = "org.jetbrains.kotlinx:kotlinx-serialization-json", version.ref = "kotlinx-serialization-json" } | |||
| android-material3 = { group = "com.google.android.material", name = "material", version.ref = "android-material3" } | |||
There was a problem hiding this comment.
We intentionally removed this dependency as it wasn't needed for Compose in general and it brings in a whole bunch of library code that isn't needed, can glance not get the theme properties from the GlanceTheme?
There was a problem hiding this comment.
This is for preview layouts. Preview layouts allow for dynamic color and dark mode support between android 12 and 15. Android 15 and up can use generated previews.
There was a problem hiding this comment.
Is there a way we can use system themes for those versions? or limit this import to only the widget module?
There was a problem hiding this comment.
It should only be imported in the glanceWidget build. Can version catalogs be in fetaure modules?
secondsun
force-pushed
the
widget_preview_updates
branch
from
d76873f to
1698f4d
Compare
Jetcaster/mobile/src/main/java/com/example/jetcaster/ui/MainActivity.kt
Outdated
Show resolved
Hide resolved
|
Warning You have reached your daily quota limit. As a reminder, free tier users are limited to 5 requests per day. Please wait up to 24 hours and I will start processing your requests again! |
secondsun
force-pushed
the
widget_preview_updates
branch
from
0343050 to
d2171cc
Compare
secondsun
force-pushed
the
widget_preview_updates
branch
from
d2171cc to
2c6678f
Compare
This PR