Skip to content

Commit

Permalink
Merge pull request buildkite#265 from buildkite/aws-https-by-default
Browse files Browse the repository at this point in the history
Make S3 URLs HTTPS by default
  • Loading branch information
toolmantim committed Mar 17, 2016
2 parents c734825 + fe92221 commit 1fd5a43
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion agent/s3_uploader.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ func (u *S3Uploader) Setup(destination string, debugHTTP bool) error {
}

func (u *S3Uploader) URL(artifact *api.Artifact) string {
baseUrl := "http://" + u.BucketName() + ".s3.amazonaws.com"
baseUrl := "https://" + u.BucketName() + ".s3.amazonaws.com"

if os.Getenv("BUILDKITE_S3_ACCESS_URL") != "" {
baseUrl = os.Getenv("BUILDKITE_S3_ACCESS_URL")
Expand Down

0 comments on commit 1fd5a43

Please sign in to comment.