Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(@schematics/angular): use generateFromFiles helper in more cases #30011

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 2, 2025

The class, directive, interface, and service schematics now more fully use the generateFromFiles helper. This reduces repeat code within each schematic. In some cases the schematic has been reduced to a single call to the helper.

… cases

The class, directive, interface, and service schematics now more fully
use the `generateFromFiles` helper.  This reduces repeat code within each
schematic. In some cases the schematic has been reduced to a single call
to the helper.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 2, 2025
@clydin clydin marked this pull request as ready for review April 2, 2025 17:31
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 2, 2025
@clydin clydin requested a review from alan-agius4 April 2, 2025 17:32
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 3, 2025
@clydin clydin merged commit 322f6ec into angular:main Apr 3, 2025
35 checks passed
@clydin clydin deleted the schematics/common-file-generate branch April 3, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants