Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): generate guards with a dash type separator #30029

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 4, 2025

To align with the updated style guide, Angular v20 will generate guards with file extension guard type prefixed with a - separator instead of a . by default. Projects will automatically use this naming convention. Projects can however opt-out by setting the typeSeparator option to . for the guard schematic. This can be done as a default in the angular.json or directly on the commandline via --type-separator=. when executing ng generate. As an example, example.guard.ts will now be named example-guard.ts. The TypeScript declaration will continue to contain Guard such as with ExampleGuard.

To align with the updated style guide, Angular v20 will generate guards
with file extension `guard` type prefixed with a `-` separator instead of
a `.` by default. Projects will automatically use this naming convention.
Projects can however opt-out by setting the `typeSeparator` option to `.`
for the guard schematic. This can be done as a default in the `angular.json`
or directly on the commandline via `--type-separator=.` when executing `ng generate`.
As an example, `example.guard.ts` will now be named `example-guard.ts`.
The TypeScript declaration will continue to contain `Guard` such as with `ExampleGuard`.
@clydin clydin added the target: major This PR is targeted for the next major release label Apr 4, 2025
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2025
@clydin clydin requested a review from alan-agius4 April 4, 2025 15:19
@clydin clydin marked this pull request as ready for review April 4, 2025 15:19
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 4, 2025
@jkrems jkrems merged commit 5fc5951 into angular:main Apr 4, 2025
35 checks passed
@clydin clydin deleted the style-guide/pipes branch April 4, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants