Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): generate resolvers with a dash type separator #30032

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 4, 2025

To align with the updated style guide, Angular v20 will generate resolvers with file extension resolver type prefixed with a - separator instead of a . by default. Projects will automatically use this naming convention. Projects can however opt-out by setting the typeSeparator option to . for the resolver schematic. This can be done as a default in the angular.json or directly on the commandline via --type-separator=. when executing ng generate. As an example, example.resolver.ts will now be named example-resolver.ts. The TypeScript declaration will continue to contain Resolver such as with ExampleResolver.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 4, 2025
@clydin clydin marked this pull request as ready for review April 4, 2025 16:04
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Apr 4, 2025
@clydin clydin requested a review from alan-agius4 April 4, 2025 16:05
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please add a description to the new option in the schema.json?

@clydin clydin force-pushed the style-guide/resolver branch from c91e18f to c4a6e5a Compare April 4, 2025 18:08
To align with the updated style guide, Angular v20 will generate resolvers
with file extension `resolver` type prefixed with a `-` separator instead of
a `.` by default. Projects will automatically use this naming convention.
Projects can however opt-out by setting the `typeSeparator` option to `.`
for the resolver schematic. This can be done as a default in the `angular.json`
or directly on the commandline via `--type-separator=.` when executing `ng generate`.
As an example, `example.resolver.ts` will now be named `example-resolver.ts`.
The TypeScript declaration will continue to contain `Resolver` such as with `ExampleResolver`.
@clydin clydin force-pushed the style-guide/resolver branch from c4a6e5a to 055a654 Compare April 4, 2025 18:11
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Apr 4, 2025
@clydin clydin merged commit 92e193c into angular:main Apr 4, 2025
31 checks passed
@clydin clydin deleted the style-guide/resolver branch April 4, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker area: @schematics/angular target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants