perf(cdk-experimental/column-resize): improve hover responsiveness of… #30708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielolaru91
requested review from
crisbeto and
wagnermaciel
and removed request for
a team
danielolaru91
force-pushed
the
perf/cdk-experimental/column-resize/hover
branch
3 times, most recently
from
3095513 to
2bd3220
Compare
mmalerba
requested changes
Mar 27, 2025
mmalerba
approved these changes
Mar 31, 2025
mmalerba
added
action: merge
… column resize with requestAnimationFrame Improve column resize performance when calling the `_updateOverlayHandleHeight()` method in the `cdk-experimental` column resize feature. By wrapping the `updateSize` call inside a `requestAnimationFrame()`, the height update is deferred to the next repaint, improving responsiveness during hover interactions.
… column resize with requestAnimationFrame use afterNextRender write phase instead
mmalerba
force-pushed
the
perf/cdk-experimental/column-resize/hover
branch
from
45f1dd7 to
d99fbd3
Compare
…ness of column resize with requestAnimationFrame
mmalerba
pushed a commit
that referenced
this pull request
Apr 2, 2025
#30708) * perf(cdk-experimental/column-resize): improve hover responsiveness of column resize with requestAnimationFrame Improve column resize performance when calling the `_updateOverlayHandleHeight()` method in the `cdk-experimental` column resize feature. By wrapping the `updateSize` call inside a `requestAnimationFrame()`, the height update is deferred to the next repaint, improving responsiveness during hover interactions. * perf(cdk-experimental/column-resize): improve hover responsiveness of column resize with requestAnimationFrame use afterNextRender write phase instead * fixup! perf(cdk-experimental/column-resize): improve hover responsiveness of column resize with requestAnimationFrame --------- Co-authored-by: Miles Malerba <[email protected]> (cherry picked from commit dd69023)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… column resize with requestAnimationFrame
This PR suggests a performance improvement for the
_updateOverlayHandleHeight()method in thecdk-experimentalcolumn resize feature. Currently, the method immediately updates the overlay handle height when hovering over a resizable column header. By wrapping theupdateSizecall inside arequestAnimationFrame(), the height update is deferred to the next repaint, improving responsiveness during hover interactions.Why this change is suggested:
The current implementation causes the height update to occur immediately, potentially resulting in unnecessary reflows or stuttering, when hovering over column headers. By using
requestAnimationFrame(), we defer the update until the next browser repaint, allowing for smoother performance and reducing the chance of layout thrashing during hover, particularly in pages with complex DOM structures.Changes:
overlayRef.updateSize()call inside arequestAnimationFrame()to ensure the height update occurs on the next repaint, rather than immediately during hover.