Make powerful globals explicit (Agoric#2594)

* fix: make powerful globals explicit

golang/cosmos/src/index.js

@@ -1 +1,2 @@
+/* global module require */
 module.exports = require('bindings')('agcosmosdaemon.node');

packages/ERTP/test/swingsetTests/splitPayments/test-splitPayments.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import test from 'ava';
 import { loadBasedir, buildVatController } from '@agoric/swingset-vat';
 import path from 'path';

packages/SwingSet/src/controller.js

@@ -1,3 +1,4 @@
+/* global require */
 import fs from 'fs';
 import process from 'process';
 import re2 from 're2';

packages/SwingSet/src/devices/bridge.js

@@ -1,3 +1,4 @@
+/* global require */
 /*
   The 'bridge' devices provides bidirectional function calls between objects
   on the host and code within a swingset.

packages/SwingSet/src/devices/command.js

@@ -1,3 +1,4 @@
+/* global require */
 import { makePromiseKit } from '@agoric/promise-kit';
 import { Nat } from '@agoric/nat';
 

packages/SwingSet/src/devices/loopbox.js

@@ -1,3 +1,4 @@
+/* global require */
 import { assert, details as X } from '@agoric/assert';
 
 /*

packages/SwingSet/src/devices/mailbox.js

@@ -1,3 +1,4 @@
+/* global require */
 /*
   The 'mailbox' device helps manage bidirectional communication with a number
   of 'peers'. Each peer is identified with a string. We exchange ordered

packages/SwingSet/src/devices/plugin.js

@@ -1,3 +1,4 @@
+/* global require */
 export function buildPlugin(pluginDir, pluginRequire, queueThunkForKernel) {
   const srcPath = require.resolve('./plugin-src');
   let resetter;

packages/SwingSet/src/devices/timer.js

@@ -1,3 +1,4 @@
+/* global require */
 import { Nat } from '@agoric/nat';
 
 import { assert, details as X } from '@agoric/assert';

packages/SwingSet/src/initializeSwingset.js

@@ -1,3 +1,4 @@
+/* global require */
 import fs from 'fs';
 import path from 'path';
 

packages/SwingSet/src/kernel/vatManager/supervisor-nodeworker-cjs.js

@@ -1,3 +1,4 @@
+/* global module require */
 // `tap` and `node -r esm` were able to allow the swingset process to create
 // a thread (`new Worker()`) from the (ESM) supervisor file without problems,
 // but for some reason AVA cannot. The file loaded into the new thread

packages/SwingSet/src/kernel/vatManager/supervisor-subprocess-xsnap.js

@@ -1,3 +1,4 @@
+/* global globalThis */
 // @ts-check
 import { assert, details as X } from '@agoric/assert';
 import { importBundle } from '@agoric/import-bundle';

packages/SwingSet/src/main.js

@@ -1 +1,2 @@
+/* global module require */
 module.exports = require('./index.js');

packages/SwingSet/src/netstring.js

@@ -1,3 +1,4 @@
+/* global require Buffer */
 import { assert, details as X } from '@agoric/assert';
 
 // adapted from 'netstring-stream', https://github.com/tlivings/netstring-stream/

packages/SwingSet/src/waitUntilQuiescent.js

@@ -1,3 +1,4 @@
+/* global setImmediate */
 import { makePromiseKit } from '@agoric/promise-kit';
 
 // This can only be imported from the Start Compartment, where 'setImmediate'

packages/SwingSet/src/weakref.js

@@ -1,3 +1,4 @@
+/* global globalThis */
 import { assert, details as X } from '@agoric/assert';
 
 const { defineProperties } = Object;

packages/SwingSet/src/worker-protocol.js

@@ -1,3 +1,4 @@
+/* global Buffer */
 import { Transform } from 'stream';
 
 // Transform objects which convert from hardened Arrays of JSON-serializable

packages/SwingSet/test/definition/test-vat-definition.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { buildVatController } from '../../src/index';

packages/SwingSet/test/device-plugin/test-device.js

@@ -1,3 +1,4 @@
+/* global require __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/metering/test-dynamic-vat-metered.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-metering-and-ses';
 import bundleSource from '@agoric/bundle-source';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/metering/test-dynamic-vat-subcompartment.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-metering-and-ses';
 import bundleSource from '@agoric/bundle-source';
 import test from 'ava';

packages/SwingSet/test/metering/test-dynamic-vat-unmetered.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-metering-and-ses';
 import bundleSource from '@agoric/bundle-source';
 import test from 'ava';

packages/SwingSet/test/metering/test-metering.js

@@ -1,3 +1,4 @@
+/* global require */
 // eslint-disable-next-line import/order
 import { replaceGlobalMeter } from './install-global-metering';
 import '@agoric/install-ses';

packages/SwingSet/test/metering/test-within-vat.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-metering-and-ses';
 import bundleSource from '@agoric/bundle-source';
 import test from 'ava';

packages/SwingSet/test/test-controller.js

@@ -1,3 +1,4 @@
+/* global require __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import path from 'path';

packages/SwingSet/test/test-demos-comms.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import { initSwingStore } from '@agoric/swing-store-simple';
 import test from 'ava';

packages/SwingSet/test/test-demos.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import { initSwingStore } from '@agoric/swing-store-simple';
 import test from 'ava';

packages/SwingSet/test/test-device-bridge.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/test-devices.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '@agoric/bundle-source';

packages/SwingSet/test/test-exomessages.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { buildVatController } from '../src/index';

packages/SwingSet/test/test-marshal.js

@@ -1,3 +1,4 @@
+/* global setImmediate */
 import '@agoric/install-ses';
 import { Far } from '@agoric/marshal';
 import test from 'ava';

packages/SwingSet/test/test-message-patterns.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 /* eslint no-await-in-loop: "off" */
 /* eslint dot-notation: "off" */
 /* eslint object-shorthand: "off" */

packages/SwingSet/test/test-netstring.js

@@ -1,3 +1,4 @@
+/* global Buffer */
 import '@agoric/install-ses'; // adds 'harden' to global
 
 import test from 'ava';

packages/SwingSet/test/test-promises.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import path from 'path';

packages/SwingSet/test/test-syscall-failure.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/test-tildot.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { buildVatController } from '../src/index';

packages/SwingSet/test/test-transcript-light.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import path from 'path';

packages/SwingSet/test/test-transcript.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import path from 'path';

packages/SwingSet/test/test-vattp.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/test-worker-protocol.js

@@ -1,3 +1,4 @@
+/* global Buffer */
 import '@agoric/install-ses'; // adds 'harden' to global
 
 import test from 'ava';

packages/SwingSet/test/timer-device/test-device.js

@@ -1,3 +1,4 @@
+/* global require */
 import '@agoric/install-ses';
 import test from 'ava';
 import { initSwingStore } from '@agoric/swing-store-simple';

packages/SwingSet/test/vat-admin/terminate/test-terminate.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import path from 'path';
 import test from 'ava';

packages/SwingSet/test/vat-admin/test-innerVat.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-metering-and-ses';
 import path from 'path';
 import test from 'ava';

packages/SwingSet/test/vat-admin/test-replay.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-metering-and-ses';
 import path from 'path';
 import test from 'ava';

packages/SwingSet/test/virtualObjects/test-representatives.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import path from 'path';
 import test from 'ava';

packages/SwingSet/test/workers/test-worker.js

@@ -1,3 +1,4 @@
+/* global require __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import { loadBasedir, buildVatController } from '../../src/index';

packages/SwingSet/tools/prepare-test-env.js

@@ -1,3 +1,4 @@
+/* global globalThis */
 /**
  * Prepare Agoric SwingSet vat global environment for testing.
  *

packages/acorn-eventual-send/index.js

@@ -1,3 +1,4 @@
+/* global module */
 const tilde = '~'.charCodeAt(0);
 const dot = '.'.charCodeAt(0);
 const zero = '0'.charCodeAt(0);

packages/acorn-eventual-send/test/test-rollup.js

@@ -1,3 +1,4 @@
+/* global require */
 import test from 'ava';
 import { rollup } from 'rollup/dist/rollup.es';
 import * as acorn from 'acorn';

packages/agoric-cli/integration-tests/test-workflow.js

@@ -1,3 +1,4 @@
+/* global __dirname process setTimeout clearTimeout setInterval clearInterval */
 /* eslint-disable import/no-extraneous-dependencies */
 import '@agoric/install-ses';
 import test from 'ava';

packages/agoric-cli/lib/anylogger-agoric.js

@@ -1,3 +1,4 @@
+/* global process */
 import anylogger from 'anylogger';
 import chalk from 'chalk';
 

packages/agoric-cli/lib/deploy.js

@@ -1,3 +1,4 @@
+/* global require process setTimeout setInterval clearInterval */
 /* eslint-disable no-await-in-loop */
 import { E, makeCapTP } from '@agoric/captp';
 import { makePromiseKit } from '@agoric/promise-kit';

packages/agoric-cli/lib/entrypoint.js

@@ -1,3 +1,4 @@
+/* global process */
 import '@agoric/install-ses';
 
 import path from 'path';

packages/agoric-cli/lib/helpers.js

@@ -1,3 +1,4 @@
+/* global process */
 // @ts-check
 
 /** @typedef {import('child_process').ChildProcess} ChildProcess */

packages/agoric-cli/lib/install.js

@@ -1,3 +1,4 @@
+/* global __dirname process */
 import path from 'path';
 import chalk from 'chalk';
 import { makePspawn } from './helpers';

packages/agoric-cli/lib/main.js

@@ -1,3 +1,4 @@
+/* global __dirname process */
 import { Command } from 'commander';
 
 import { assert, details as X } from '@agoric/assert';

packages/agoric-cli/lib/open.js

@@ -1,3 +1,4 @@
+/* global process setInterval clearInterval */
 import { promises as defaultFs } from 'fs';
 import opener from 'opener';
 import crypto from 'crypto';

packages/agoric-cli/lib/start.js

@@ -1,3 +1,4 @@
+/* global __dirname process setTimeout */
 import path from 'path';
 import chalk from 'chalk';
 import { createHash } from 'crypto';

packages/agoric-cli/test/test-main.js

@@ -1,3 +1,4 @@
+/* global globalThis */
 import test from 'ava';
 import '@agoric/install-ses';
 import fs from 'fs';

packages/assert/src/assert.js

@@ -1,3 +1,4 @@
+/* global globalThis */
 // Copyright (C) 2019 Agoric, under Apache License 2.0
 // @ts-check
 

packages/bundle-source/demo/dir1/sub/more.js

@@ -1,3 +1,4 @@
+/* global exports require */
 const things = require('./things.js');
 
 exports.more = `have more ${things.description}`;

packages/bundle-source/demo/dir1/sub/things.js

@@ -1 +1,2 @@
+/* global exports */
 exports.description = 'many different things';

packages/bundle-source/src/index.js

@@ -1,3 +1,4 @@
+/* global process */
 import fs from 'fs';
 import { rollup as rollup0 } from 'rollup';
 import path from 'path';

packages/bundle-source/test/sanity.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 // 'lockdown' appears on the global as a side-effect of importing 'ses'
 import 'ses';
 

packages/bundle-source/test/test-bigint-transform.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '..';

packages/bundle-source/test/test-circular.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '..';

packages/bundle-source/test/test-comment.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '..';

packages/bundle-source/test/test-external-fs.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '..';

packages/bundle-source/test/test-tildot-transform.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import '@agoric/install-ses';
 import test from 'ava';
 import bundleSource from '..';

packages/cosmic-swingset/calc-gci.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+/* global require */
 
 const fs = require('fs');
 const djson = require('deterministic-json');

packages/cosmic-swingset/calc-rpcport.js

@@ -1,4 +1,5 @@
 #!/usr/bin/env node
+/* global require */
 
 // NOTE: Runs outside SES
 

packages/cosmic-swingset/lib/ag-solo/add-chain.js

@@ -1,3 +1,4 @@
+/* global process */
 import fetch from 'node-fetch';
 import crypto from 'crypto';
 import djson from 'deterministic-json';

packages/cosmic-swingset/lib/ag-solo/batched-deliver.js

@@ -1,3 +1,4 @@
+/* global setTimeout clearTimeout */
 const DEFAULT_BATCH_TIMEOUT_MS = 1000;
 
 export function makeBatchedDeliver(

packages/cosmic-swingset/lib/ag-solo/chain-cosmos-sdk.js

@@ -1,3 +1,4 @@
+/* global setTimeout */
 import path from 'path';
 import fs from 'fs';
 import { execFile } from 'child_process';

packages/cosmic-swingset/lib/ag-solo/entrypoint.js

@@ -1,4 +1,5 @@
 #! /usr/bin/env node
+/* global module require */
 
 const esmRequire = require('esm')(module);
 

packages/cosmic-swingset/lib/ag-solo/fake-chain.js

@@ -1,3 +1,4 @@
+/* global process setTimeout clearTimeout */
 /* eslint-disable no-await-in-loop */
 import path from 'path';
 import fs from 'fs';

packages/cosmic-swingset/lib/ag-solo/html/main.js

@@ -1,3 +1,4 @@
+/* global setTimeout */
 // NOTE: Runs outside SES
 
 /* global WebSocket fetch document window walletFrame localStorage */

packages/cosmic-swingset/lib/ag-solo/init-basedir.js

@@ -1,3 +1,4 @@
+/* global __dirname Buffer */
 import fs from 'fs';
 import path from 'path';
 import { execFileSync } from 'child_process';

packages/cosmic-swingset/lib/ag-solo/main.js

@@ -1,3 +1,4 @@
+/* global __dirname */
 import fs from 'fs';
 import path from 'path';
 import parseArgs from 'minimist';

packages/cosmic-swingset/lib/ag-solo/start.js

@@ -1,3 +1,4 @@
+/* global require process setTimeout */
 import fs from 'fs';
 import path from 'path';
 import temp from 'temp';