Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reminder question time elapsed #17774

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gayatriii0803
Copy link
Contributor

Purpose / Description

Auto Advance "Question time elapsed" reminder does not work

Fixes

Approach

show snackbar on automaticShowAnswer()

How Has This Been Tested?

Physical device (OPPO F21 Pro 5G).

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@lukstbit lukstbit added the Needs Author Reply Waiting for a reply from the original author label Jan 9, 2025
@gayatriii0803
Copy link
Contributor Author

I don't understand why this fails. Is this related to my code?

@mikehardy
Copy link
Member

@gayatriii0803 failure most likely unrelated:

Triggered via pull request 11 hours ago

image

Github blew up

https://www.githubstatus.com/incidents/l76qh74ryp16

image

@mikehardy mikehardy closed this Jan 9, 2025
@mikehardy mikehardy reopened this Jan 9, 2025
@mikehardy
Copy link
Member

Closing and reopening forces a CI re-run.

david-allison

This comment was marked as resolved.

@david-allison david-allison added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Jan 10, 2025
Copy link
Member

@BrayanDSO BrayanDSO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lint and tests are failing

@BrayanDSO BrayanDSO added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Jan 10, 2025
@gayatriii0803
Copy link
Contributor Author

AutomaticAnswerActionTest > testExecute FAILED
    java.lang.UnsatisfiedLinkError: 'byte[][] net.ankiweb.rsdroid.NativeMethods.openBackend(byte[])'
        at net.ankiweb.rsdroid.NativeMethods.openBackend(Native Method)
        at net.ankiweb.rsdroid.Backend.<init>(Backend.kt:79)
        at net.ankiweb.rsdroid.BackendFactory.getBackend(BackendFactory.kt:39)
        at net.ankiweb.rsdroid.BackendFactory.getBackend$default(BackendFactory.kt:35)
        at com.ichi2.anki.CollectionManager.ensureBackendInner(CollectionManager.kt:208)
        at com.ichi2.anki.CollectionManager.access$ensureBackendInner(CollectionManager.kt:41)
        at com.ichi2.anki.CollectionManager$getBackend$1.invokeSuspend$lambda$0(CollectionManager.kt:153)
        at com.ichi2.anki.CollectionManager$withQueue$3.invokeSuspend(CollectionManager.kt:105)
        at _COROUTINE._BOUNDARY._(CoroutineDebugging.kt:42)
        at com.ichi2.anki.CollectionManager$getBackend$1.invokeSuspend(CollectionManager.kt:153)

Can anyone help me here?

@mikehardy
Copy link
Member

@david-allison - the test using TR.... which means it needs the backend. Is @JvmTest the correct inheritance there? Or should it be `RobolectricTest ?

@david-allison
Copy link
Member

JVM - the backend shouldn't need an Android dependency

Copy link
Contributor

Hello 👋, this PR has had no activity for more than 2 weeks and needs a reply from the author. If you think this is a mistake please comment and ping a maintainer to get this merged ASAP! Thanks for contributing! You have 7 days until this gets closed automatically

@github-actions github-actions bot added the Stale label Jan 24, 2025
@github-actions github-actions bot closed this Jan 31, 2025
@SanjaySargam SanjaySargam reopened this Feb 4, 2025
@github-actions github-actions bot removed the Stale label Feb 4, 2025
@SanjaySargam SanjaySargam added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto Advance "Question time elapsed" reminder does not work
6 participants