Add validation to security price model

annujk · Oct 30, 2024 · c991767 · c991767
1 parent cd91e66
commit c991767
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/app/models/security/price.rb b/app/models/security/price.rb
@@ -3,6 +3,8 @@ class Security::Price < ApplicationRecord
 
   belongs_to :security
 
+  validates :price, :currency, presence: true
+
   class << self
     def find_price(security:, date:, cache: true)
       result = find_by(security:, date:)

diff --git a/db/schema.rb b/db/schema.rb
diff --git a/test/models/security/price_test.rb b/test/models/security/price_test.rb
@@ -36,7 +36,7 @@ class Security::PriceTest < ActiveSupport::TestCase
             .returns(
               OpenStruct.new(
                 success?: true,
-                prices: [ { date: tomorrow, price: expected_price } ]
+                prices: [ { date: tomorrow, price: expected_price, currency: "USD" } ]
               )
             )
 
@@ -89,7 +89,7 @@ class Security::PriceTest < ActiveSupport::TestCase
                   mic_code: security.exchange_mic,
                   start_date: 2.days.ago.to_date,
                   end_date: 2.days.ago.to_date)
-             .returns(OpenStruct.new(success?: true, prices: [ { date: 2.days.ago.to_date, price: missing_price } ]))
+             .returns(OpenStruct.new(success?: true, prices: [ { date: 2.days.ago.to_date, price: missing_price, currency: "USD" } ]))
              .once
 
     price1 = security_prices(:one) # AAPL today