Expose the randomness used to create descriptions. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
murisi
force-pushed
the
murisi/expose-randomness
branch
from
2e3a3ac to
fa4a51f
Compare
murisi
force-pushed
the
murisi/expose-randomness
branch
2 times, most recently
from
19d3565 to
5512c53
Compare
murisi
force-pushed
the
murisi/expose-randomness
branch
from
5512c53 to
e423e98
Compare
murisi
force-pushed
the
murisi/expose-randomness
branch
from
e423e98 to
b5f570f
Compare
2 tasks
grarco
approved these changes
Apr 22, 2024
XuyangSong
reviewed
Apr 25, 2024
There was a problem hiding this comment.
The randomness is already set back to the SaplingProvingContext as the bsk, right? Do we still need to explicitly expose it from spend/output/convert_proof function?
I might not have the right background. It seems like you want to rebuild the value commitments somewhere else, so you need to expose all the randomness?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the course of hardware wallet implementation, it became apparent that value commitment randomness needs to be communicated to the hardware in order to allow the signing of MASP transactions in one round. This PR addresses this by exposing the randomness that was used to create value commitments in the spend, convert, and output descriptions. More precisely, it does this by extending the
SaplingMetadatasection to includespend_rcvs: Vec<jubjub:Fr>,convert_rcvs: Vec<jubjub:Fr>, andoutput_rcvs: Vec<jubjub:Fr>vectors that map positions in the description vectors to the randomness used to generate their value commitment.