MDL-18644 Bugs found by syntax checker, merged from MOODLE_19_STABLE

anovikov · Mar 23, 2009 · 081a9b0 · 081a9b0
1 parent 9fb1634
commit 081a9b0
Show file tree

Hide file tree

Showing 10 changed files with 2,231 additions and 2,232 deletions.
diff --git a/auth/cas/CAS/client.php b/auth/cas/CAS/client.php
diff --git a/lib/adodb/perf/perf-mysql.inc.php b/lib/adodb/perf/perf-mysql.inc.php
diff --git a/lib/magpie/rss_parse.inc b/lib/magpie/rss_parse.inc
@@ -587,18 +587,18 @@ function map_attrs($k, $v) {
 // courtesy, Ryan Currie, [email protected]
 
 if (!function_exists('array_change_key_case')) {
-	define("CASE_UPPER",1);
-	define("CASE_LOWER",0);
+    define("CASE_UPPER",1);
+    define("CASE_LOWER",0);
 
 
-	function array_change_key_case($array,$case=CASE_LOWER) {
-       if ($case=CASE_LOWER) $cmd=strtolower;
-       elseif ($case=CASE_UPPER) $cmd=strtoupper;
+    function array_change_key_case($array,$case=CASE_LOWER) {
+       if ($case == CASE_LOWER) $cmd=strtolower;
+       elseif ($case == CASE_UPPER) $cmd=strtoupper;
        foreach($array as $key=>$value) {
                $output[$cmd($key)]=$value;
        }
        return $output;
-	}
+    }
 
 }
 

diff --git a/login/index.php b/login/index.php
@@ -67,7 +67,7 @@
         // Handles the case of another Moodle site linking into a page on this site
         //TODO: move weblink into own auth plugin
         include($CFG->dirroot.'/login/weblinkauth.php');
-        if (function_exists(weblink_auth)) {
+        if (function_exists('weblink_auth')) {
             $user = weblink_auth($SESSION->wantsurl);
         }
         if ($user) {

diff --git a/mod/lesson/reformat.php b/mod/lesson/reformat.php
@@ -108,7 +108,7 @@ function importmodifiedaikenstyle($filename) {
             // make entry followed by '.'
             $line[1]='.';
         }
-        elseif ( ($responses AND $answer_found) OR (count(outlines)<=1) ) {
+        elseif ( ($responses AND $answer_found) OR (count($outlines)<=1) ) {
         // we have found responses and an answer and the current line is not an answer
             switch ($line[0]) {
                 case 1:

diff --git a/mod/resource/type/file/resource.class.php b/mod/resource/type/file/resource.class.php
@@ -736,7 +736,7 @@ function set_encrypted_parameter() {
 
         if (!empty($this->resource->reference) && file_exists($CFG->dirroot ."/mod/resource/type/file/externserverfile.php")) {
             include $CFG->dirroot ."/mod/resource/type/file/externserverfile.php";
-            if (function_exists(extern_server_file)) {
+            if (function_exists('extern_server_file')) {
                 return extern_server_file($this->resource->reference);
             }
         }

diff --git a/mod/resource/type/ims/deploy.php b/mod/resource/type/ims/deploy.php
@@ -254,7 +254,7 @@ function ims_extract_submanifests($data) {
                 $moresubmanifests = ims_extract_submanifests($submanifest['#']);
             /// Add them to results array
                 if (!empty($moresubmanifests)) {
-                    $submanifest_object->childs = moresubmanifests;
+                    $submanifest_object->childs = $moresubmanifests;
                 }
             /// Add submanifest object to results array
                 $submanifests[] = $submanifest_object;

diff --git a/mod/resource/type/ims/repository_deploy.php b/mod/resource/type/ims/repository_deploy.php
@@ -248,7 +248,7 @@ function ims_extract_submanifests($data) {
                 $moresubmanifests = ims_extract_submanifests($submanifest['#']);
             /// Add them to results array
                 if (!empty($moresubmanifests)) {
-                    $submanifest_object->childs = moresubmanifests;
+                    $submanifest_object->childs = $moresubmanifests;
                 }
             /// Add submanifest object to results array
                 $submanifests[] = $submanifest_object;

diff --git a/mod/resource/type/repository/resource.class.php b/mod/resource/type/repository/resource.class.php
@@ -498,7 +498,7 @@ function set_encrypted_parameter() {
 
     if (!empty($this->resource->reference) && file_exists($CFG->dirroot ."/mod/resource/type/file/externserverfile.php")) {
         include $CFG->dirroot ."/mod/resource/type/file/externserverfile.php";
-        if (function_exists(extern_server_file)) {
+        if (function_exists('extern_server_file')) {
             return extern_server_file($this->resource->reference);
         }
     }