Skip to content

Commit

Permalink
MDL-14663 "link_to_popup_window displays 'Click here....' as the link…
Browse files Browse the repository at this point in the history
… text if you pass in 0 as the link text."

Also fixing the problem in link_to_popup_window function. Test for null instead of empty.
  • Loading branch information
jamiesensei committed May 2, 2008
1 parent e49906d commit 32ba2f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/weblib.php
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ function element_to_popup_window ($type=null, $url=null, $name=null, $linkname=n
}

// get some default string, using the localized version of legacy defaults
if (!$linkname) {
if (is_null($linkname) || $linkname === '') {
$linkname = get_string('clickhere');
}
if (!$title) {
Expand Down

0 comments on commit 32ba2f0

Please sign in to comment.