core MDL-19786 Cleaned up a couple of minor deprecated calls

anovikov · Sep 22, 2010 · 8d3950e · 8d3950e
1 parent b0d038e
commit 8d3950e
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/admin/report/unsuproles/index.php b/admin/report/unsuproles/index.php
@@ -92,7 +92,7 @@
 $rs->close();
 
 if (!$problems) {
-    notify(get_string('noprolbems', 'report_unsuproles'), 'notifysuccess');
+    echo $OUTPUT->notification(get_string('noprolbems', 'report_unsuproles'), 'notifysuccess');
 } else {
     $roles = get_all_roles();
     $data = array();

diff --git a/admin/uploadpicture.php b/admin/uploadpicture.php
@@ -82,7 +82,9 @@
             echo $OUTPUT->notification(get_string('uploadpicture_cannotmovezip','admin'));
             @remove_dir($zipdir);
         } else {
-            if (!unzip_file($dstfile, $zipdir, false)) {
+            $fp = get_file_packer('application/zip');
+            $unzipresult = $fp->extract_to_pathname($dstfile, $zipdir);
+            if (!$unzipresult) {
                 echo $OUTPUT->notification(get_string('uploadpicture_cannotunzip','admin'));
                 @remove_dir($zipdir);
             } else {

diff --git a/backup/lib.php b/backup/lib.php
@@ -577,7 +577,7 @@ function import_backup_file_silently($pathtofile,$destinationcourse,$emptyfirst=
         $restore->rolesmapping = array();
         if (isset($info->roles) && is_array($info->roles)) {
             foreach ($info->roles as $id => $info) {
-                if ($newroleid = get_field('role', 'id', 'shortname', $info->shortname)) {
+                if ($newroleid = $DB->get_field('role', 'id', array('shortname' => $info->shortname))) {
                     $restore->rolesmapping[$id] = $newroleid;
                 }
             }

diff --git a/backup/restorelib.php b/backup/restorelib.php
@@ -2000,8 +2000,8 @@ function restore_precheck($id,$file,&$errorstr,$noredirect=false) {
             }
             else {
                 if (empty($noredirect)) {
-                    print_continue($CFG->wwwroot.'/backup/restore.php?backup_unique_code='.$backup_unique_code.'&launch=form&file='.$file.'&id='.$id.'&sesskey='.sesskey());
-                    print_footer();
+                    echo $OUTPUT->continue_button(new moodle_url('/backup/restore.php', array('backup_unique_code'=>$backup_unique_code, 'launch'=>'form', 'file'=>$file, 'id'=>$id, 'sesskey'=>sesskey())));
+                    echo $OUTPUT->footer();
                     die;
 
                 } else {