MDL-18403: Completion system can cause problems if grade completion i…

…s somehow enabled when completion is set to manual
anovikov · Feb 27, 2009 · ca6b2d6 · ca6b2d6
1 parent 27eef3b
commit ca6b2d6
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/lib/completionlib.php b/lib/completionlib.php
@@ -661,10 +661,11 @@ public function get_progress_all($sortfirstname=false, $groupid=0,
     }
 
     public function inform_grade_changed($cm, $item, $grade, $deleted) {
-        // Bail out now if completion is not enabled for course-module, grade
-        // is not used to compute completion, or this is a different numbered
-        // grade
+        // Bail out now if completion is not enabled for course-module, it is enabled
+        // but is set to manual, grade is not used to compute completion, or this
+        // is a different numbered grade
         if (!$this->is_enabled($cm) ||
+            $cm->completion == COMPLETION_TRACKING_MANUAL ||
             is_null($cm->completiongradeitemnumber) ||
             $item->itemnumber != $cm->completiongradeitemnumber) {