Skip to content

Commit

Permalink
MDL-32329 fixed missing phpdoc and improved coding style
Browse files Browse the repository at this point in the history
Credit goes to Aparup Banerjee for spotting this during the integration
review.
  • Loading branch information
mudrd8mz committed May 30, 2012
1 parent ead8ba3 commit e937c54
Showing 1 changed file with 5 additions and 2 deletions.
7 changes: 5 additions & 2 deletions admin/renderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,7 @@ public function install_environment_page($maturity, $envstatus, $environment_res
*
* @param double|string|int $version Moodle on-disk version
* @param array $failed list of plugins with unsatisfied dependecies
* @param moodle_url $reloadurl URL of the page to recheck the dependencies
* @return string HTML
*/
public function unsatisfied_dependencies_page($version, array $failed, moodle_url $reloadurl) {
Expand Down Expand Up @@ -682,8 +683,10 @@ public function plugins_check_table(plugin_manager $pluginman, $version, array $

$statusisboring = in_array($statuscode, array(
plugin_manager::PLUGIN_STATUS_NODB, plugin_manager::PLUGIN_STATUS_UPTODATE));
$dependenciesok = $pluginman->are_dependencies_satisfied(
$plugin->get_other_required_plugins()) && $plugin->is_core_dependency_satisfied($version);

$coredependency = $plugin->is_core_dependency_satisfied($version);
$otherpluginsdependencies = $pluginman->are_dependencies_satisfied($plugin->get_other_required_plugins());
$dependenciesok = $coredependency && $otherpluginsdependencies;

if ($options['xdep']) {
// we want to see only plugins with failed dependencies
Expand Down

0 comments on commit e937c54

Please sign in to comment.