Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add zabbix_connector module #1435

Merged
merged 7 commits into from
Dec 31, 2024

Conversation

loricvdt
Copy link
Contributor

SUMMARY

Zabbix supports data streaming connectors since version 7.0 (experimental in 6.4), so I created the Ansible module wrapping the Zabbix API.

ISSUE TYPE
  • New Module Pull Request
COMPONENT NAME

zabbix_connector

ADDITIONAL INFORMATION

Streaming feature doc: https://www.zabbix.com/documentation/current/en/manual/config/export/streaming
Follows Zabbix API: https://www.zabbix.com/documentation/current/en/manual/api/reference/connector

Copy link

codecov bot commented Dec 23, 2024

Codecov Report

Attention: Patch coverage is 91.95402% with 7 lines in your changes missing coverage. Please review.

Project coverage is 78.40%. Comparing base (645a81a) to head (8eb8cb9).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
plugins/modules/zabbix_connector.py 91.95% 5 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1435      +/-   ##
==========================================
+ Coverage   78.08%   78.40%   +0.32%     
==========================================
  Files          46       47       +1     
  Lines        5685     5848     +163     
  Branches     1433     1491      +58     
==========================================
+ Hits         4439     4585     +146     
- Misses        775      780       +5     
- Partials      471      483      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pyrodie18
Copy link
Collaborator

Looks good, please add your change fragment.

@loricvdt
Copy link
Contributor Author

Sure, thanks. I didn't include it at first since the Ansible doc mentions it is not needed for new modules:

You do not need a changelog fragment for PRs that:

  • add new modules and plugins, because Ansible tooling does that automatically;
  • contain only documentation changes.

@pyrodie18 pyrodie18 merged commit a0f5d37 into ansible-collections:main Dec 31, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants