Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zabbix_inventory - do not require login credentials when auth_token is provided #1439

Merged
merged 2 commits into from
Dec 31, 2024
Merged

zabbix_inventory - do not require login credentials when auth_token is provided #1439

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0717b20
Do not require login credentials when auth_token is provided
mu1f407 Dec 30, 2024
571da4c
Fix yaml indentation
mu1f407 Dec 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelogs/fragments/1439-inventory-required-fix.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
bugfixes:
- zabbix inventory plugin - do not require ``login_user`` and ``login_password`` to be present
when ``auth_token`` is provided (https://github.com/ansible-collections/community.zabbix/pull/1439).
3 changes: 0 additions & 3 deletions plugins/inventory/zabbix_inventory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,22 +190,19 @@
description:
- Zabbix user name.
type: str
required: true
env:
- name: ZABBIX_USERNAME
login_password:
description:
- Zabbix user password.
type: str
required: true
env:
- name: ZABBIX_PASSWORD
auth_token:
description:
- Zabbix authentication token (see https://www.zabbix.com/documentation/current/en/manual/web_interface/frontend_sections/users/api_tokens)
- If provided then C(login_user) and C(login_password) are ignored
type: str
required: false
http_login_user:
description:
- Basic Auth login
Expand Down
Loading