Skip to content

Commit

Permalink
os: skip TestStartProcess and TestHostname on android
Browse files Browse the repository at this point in the history
Updates golang#11268.

Change-Id: Ib0cabd1c1806e884df9e40f6a9a1cdecf2f76823
Reviewed-on: https://go-review.googlesource.com/11223
Reviewed-by: David Crawshaw <[email protected]>
  • Loading branch information
cixtor committed Jun 19, 2015
1 parent 82020f8 commit 3269683
Showing 1 changed file with 7 additions and 4 deletions.
11 changes: 7 additions & 4 deletions src/os/os_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -799,11 +799,14 @@ func TestStartProcess(t *testing.T) {

var dir, cmd string
var args []string
if runtime.GOOS == "windows" {
switch runtime.GOOS {
case "android":
t.Skip("android doesn't have /bin/pwd")
case "windows":
cmd = Getenv("COMSPEC")
dir = Getenv("SystemRoot")
args = []string{"/c", "cd"}
} else {
default:
cmd = "/bin/pwd"
dir = "/"
args = []string{}
Expand Down Expand Up @@ -1252,8 +1255,8 @@ func TestHostname(t *testing.T) {
// There is no other way to fetch hostname on windows, but via winapi.
// On Plan 9 it can be taken from #c/sysname as Hostname() does.
switch runtime.GOOS {
case "plan9":
t.Skipf("skipping on %s", runtime.GOOS)
case "android", "plan9":
t.Skipf("%s doesn't have /bin/hostname", runtime.GOOS)
case "windows":
testWindowsHostname(t)
return
Expand Down

0 comments on commit 3269683

Please sign in to comment.