Skip to content

Commit

Permalink
Make subsystem dep explicit for RSC compile (pantsbuild#8406)
Browse files Browse the repository at this point in the history
Running rsc fails without this for me; not sure how the integration
tests are passing...
  • Loading branch information
illicitonion authored and wisechengyi committed Oct 7, 2019
1 parent 33a6d51 commit daf3019
Showing 1 changed file with 5 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,10 @@ class RscCompile(ZincCompile, MirroredTargetOptionMixin):
_name = 'mixed' # noqa
compiler_name = 'rsc'

@classmethod
def subsystem_dependencies(cls):
return super().subsystem_dependencies() + (Rsc,)

@memoized_property
def mirrored_target_option_actions(self):
return {
Expand All @@ -120,7 +124,7 @@ def mirrored_target_option_actions(self):

@classmethod
def implementation_version(cls):
return super().implementation_version() + [('RscCompile', 173)]
return super().implementation_version() + [('RscCompile', 174)]

class JvmCompileWorkflowType(enum(['zinc-only', 'zinc-java', 'rsc-and-zinc'])):
"""Target classifications used to correctly schedule Zinc and Rsc jobs.
Expand Down

0 comments on commit daf3019

Please sign in to comment.