upgrade-interactive exit success when no upgrades (yarnpkg#4261)

* [yarnpkg#4259] upgrade-interactive exit success when no upgrades
* added test for upgrade-interactive all up to date

__tests__/commands/upgrade-interactive.js

@@ -10,7 +10,6 @@ jasmine.DEFAULT_TIMEOUT_INTERVAL = 90000;
 const path = require('path');
 
 const fixturesLoc = path.join(__dirname, '..', 'fixtures', 'upgrade-interactive');
-// I would have named it `runUpgradeInteractive`, but that was causing linting to fail.
 const runUpgrade = buildRun.bind(null, ConsoleReporter, fixturesLoc, (args, flags, config, reporter): Promise<void> => {
   return upgradeInteractive(config, reporter, flags, args);
 });
@@ -27,3 +26,10 @@ test.concurrent('throws if lockfile is out of date', (): Promise<void> => {
     }
   });
 });
+
+test.concurrent('exits with success if no upgrades', (): Promise<void> => {
+  const reporter = new reporters.ConsoleReporter({});
+  return runUpgrade([], {}, 'up-to-date', (config, rep, install, output): ?Promise<void> => {
+    expect(output()).toContain(reporter.lang('allDependenciesUpToDate'));
+  });
+});

__tests__/fixtures/upgrade-interactive/up-to-date/package.json

@@ -0,0 +1,9 @@
+{
+  "name": "yarn-test",
+  "version": "1.0.0",
+  "main": "index.js",
+  "license": "MIT",
+  "dependencies": {
+    "left-pad": "^1.1.3"
+  }
+}

__tests__/fixtures/upgrade-interactive/up-to-date/yarn.lock

@@ -0,0 +1,7 @@
+# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
+# yarn lockfile v1
+
+
+left-pad@^1.1.3:
+  version "1.1.3"
+  resolved "https://registry.yarnpkg.com/left-pad/-/left-pad-1.1.3.tgz#612f61c033f3a9e08e939f1caebeea41b6f3199a"

src/cli/commands/upgrade-interactive.js

@@ -44,6 +44,11 @@ export async function run(config: Config, reporter: Reporter, flags: Object, arg
     [outdatedFieldName]: 'to'.length,
   };
 
+  if (deps.length === 0) {
+    reporter.success(reporter.lang('allDependenciesUpToDate'));
+    return;
+  }
+
   if (flags.latest) {
     maxLengthArr.range = 'latest'.length;
   }