Fixes palantir#115 -- no-unused-variable works for static class members

antweiss · Mar 17, 2014 · 7dfb936 · 7dfb936
1 parent aeb9477
commit 7dfb936
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,7 @@
 Change Log
 ===
 
+* [bug] `no-unused-variable` rule no longer triggers false positives for class members labeled only `static`
 * [bug] `no-unused-expression` rule no longer triggers false positives for `"use strict";` expressions
 
 v0.4.7

diff --git a/src/rules/noUnusedVariableRule.ts b/src/rules/noUnusedVariableRule.ts
@@ -116,13 +116,8 @@ class NoUnusedVariablesWalker extends Lint.RuleWalker {
     public visitMemberVariableDeclaration(node: TypeScript.MemberVariableDeclarationSyntax): void {
         var modifiers = node.modifiers;
 
-        // if no modifier is specified, the default is public, so skip the current declaration
-        if (modifiers.childCount() === 0) {
-            this.skipVariableDeclaration = true;
-        }
-
-        // if an explicit 'public' modifier is specified, skip the current declaration
-        if (this.hasModifier(modifiers, TypeScript.SyntaxKind.PublicKeyword)) {
+        // unless an explicit 'private' modifier is specified, variable is public, so skip the current declaration
+        if (!this.hasModifier(modifiers, TypeScript.SyntaxKind.PrivateKeyword)) {
             this.skipVariableDeclaration = true;
         }
 

diff --git a/test/files/rules/nounusedvariable-class.test.ts b/test/files/rules/nounusedvariable-class.test.ts
@@ -18,4 +18,5 @@ class ABCD {
     private mfunc4() {
         //
     }
+    static stillPublic: number;
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -18,4 +18,5 @@ class ABCD { @@
         private mfunc4() {
             //
         }
+        static stillPublic: number;
     }