Skip to content

Commit

Permalink
Handle script parsers whose script versions have been deleted
Browse files Browse the repository at this point in the history
  • Loading branch information
Chris7 committed Apr 12, 2020
1 parent a295461 commit 2866280
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
3 changes: 2 additions & 1 deletion wooey/models/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,8 @@ class ScriptParser(WooeyPy2Mixin, models.Model):
script_version = models.ManyToManyField('ScriptVersion')

def __str__(self):
return '{}: {}'.format(self.script_version.first().script.script_name, self.name)
script_version = self.script_version.first()
return '{}: {}'.format(script_version.script.script_name if script_version else 'No Script Assigned', self.name)


class ScriptParameter(UpdateScriptsMixin, WooeyPy2Mixin, models.Model):
Expand Down
5 changes: 5 additions & 0 deletions wooey/tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ class ScriptGroupTestCase(TestCase):
def test_script_group_creation(self):
group = factories.ScriptGroupFactory()

class TestScriptParsers(mixins.ScriptFactoryMixin, TestCase):
def test_renders_if_script_version_deleted(self):
parser = self.choice_script.scriptparser_set.first()
self.choice_script.delete()
self.assertIn(parser.name, str(parser))

class ScriptParameterTestCase(TestCase):
def test_script_parameter_default(self):
Expand Down

0 comments on commit 2866280

Please sign in to comment.