Skip to content

Commit

Permalink
[OpenCL] Re-enable supported core extensions based on opencl version …
Browse files Browse the repository at this point in the history
…when disabling all extensions using pragma

Differential Revision: https://reviews.llvm.org/D28257


git-svn-id: https://llvm.org/svn/llvm-project/cfe/trunk@291243 91177308-0d34-0410-b5e6-96231b3b80d8
  • Loading branch information
kzhuravl committed Jan 6, 2017
1 parent 5f335c7 commit 6e36bc2
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 2 deletions.
6 changes: 4 additions & 2 deletions lib/Parse/ParsePragma.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -506,10 +506,12 @@ void Parser::HandlePragmaOpenCLExtension() {
// overriding all previously issued extension directives, but only if the
// behavior is set to disable."
if (Name == "all") {
if (State == Disable)
if (State == Disable) {
Opt.disableAll();
else
Opt.enableSupportedCore(getLangOpts().OpenCLVersion);
} else {
PP.Diag(NameLoc, diag::warn_pragma_expected_predicate) << 1;
}
} else if (State == Begin) {
if (!Opt.isKnown(Name) ||
!Opt.isSupported(Name, getLangOpts().OpenCLVersion)) {
Expand Down
13 changes: 13 additions & 0 deletions test/SemaOpenCL/extensions.cl
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@
// RUN: %clang_cc1 %s -triple spir-unknown-unknown -verify -pedantic -fsyntax-only -cl-ext=-all -cl-ext=+cl_khr_fp64 -cl-ext=+cl_khr_fp16 -cl-ext=-cl_khr_fp64 -DNOFP64
// RUN: %clang_cc1 %s -triple spir-unknown-unknown -verify -pedantic -fsyntax-only -cl-ext=-all -cl-ext=+cl_khr_fp64,-cl_khr_fp64,+cl_khr_fp16 -DNOFP64

// Test with -finclude-default-header, which includes opencl-c.h. opencl-c.h
// disables all extensions by default, but supported core extensions for a
// particular OpenCL version must be re-enabled (for example, cl_khr_fp64 is
// enabled by default with -cl-std=CL2.0).
//
// RUN: %clang_cc1 %s -triple amdgcn-unknown-unknown -verify -pedantic -fsyntax-only -cl-std=CL2.0 -finclude-default-header

#ifdef _OPENCL_H_
// expected-no-diagnostics
#endif

#ifdef FP64
// expected-no-diagnostics
#endif
Expand All @@ -33,13 +44,15 @@ void f1(double da) { // expected-error {{type 'double' requires cl_khr_fp64 exte
}
#endif

#ifndef _OPENCL_H_
int isnan(float x) {
return __builtin_isnan(x);
}

int isfinite(float x) {
return __builtin_isfinite(x);
}
#endif

#pragma OPENCL EXTENSION cl_khr_fp64 : enable
#ifdef NOFP64
Expand Down

0 comments on commit 6e36bc2

Please sign in to comment.