Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bluriness when there is multiple different outputs scaling values #46

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Fix bluriness when there is multiple different outputs scaling values #46

merged 2 commits into from
Feb 12, 2025

Conversation

stacyharper
Copy link
Contributor

@stacyharper stacyharper force-pushed the wbarraco/push-vmprxsuskvpy branch from ef15eab to 500a648 Compare February 10, 2025 08:21
@stacyharper
Copy link
Contributor Author

I'm a bit annoyed by this link2, but is there a better way?

any1
any1 reviewed Feb 10, 2025
View reviewed changes
Copy link
Owner

@any1 any1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe "Fix blurriness when there are multiple output scaling values" is the more conventional way of saying this?

src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
src/main.c Outdated Show resolved Hide resolved
@stacyharper stacyharper force-pushed the wbarraco/push-vmprxsuskvpy branch 2 times, most recently from 37c5c4c to 5ee08a6 Compare February 10, 2025 10:44
@stacyharper
Copy link
Contributor Author

Maybe it's better to just mark the outputs instead using a variable named something like has_surface.

I reworked those patch this way, and applied your recommandations.

@stacyharper
Fix bluriness when there are multiple different outputs scaling values
155aa6c 
To do so, we filter outputs that the surface has not entered when
computing the max scale on the list.
@stacyharper
Use the provided preferred buffer scale value when available
61b3086 
This is available on version 6 or later. So we keep our own code to be
retro-compatible.
@stacyharper stacyharper force-pushed the wbarraco/push-vmprxsuskvpy branch from 5ee08a6 to 61b3086 Compare February 10, 2025 10:49
@any1 any1 merged commit e2f6ab7 into any1:master Feb 12, 2025
@any1
Copy link
Owner

any1 commented Feb 12, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@any1 any1 any1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stacyharper @any1