builtin/time: Add tests for CURRENT_TIME(), CURTIME()

anywhy · Dec 20, 2015 · 2184577 · 2184577
1 parent 1b0c2e3
commit 2184577
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/expression/builtin/time_test.go b/expression/builtin/time_test.go
@@ -275,3 +275,12 @@ func (s *testBuiltinSuite) TestCurrentDate(c *C) {
 	c.Assert(ok, IsTrue)
 	c.Assert(n.String(), GreaterEqual, last.Format(mysql.DateFormat))
 }
+
+func (s *testBuiltinSuite) TestCurrentTime(c *C) {
+	last := time.Now()
+	v, err := builtinCurrentTime(nil, nil)
+	c.Assert(err, IsNil)
+	n, ok := v.(mysql.Time)
+	c.Assert(ok, IsTrue)
+	c.Assert(n.String(), GreaterEqual, last.Format(mysql.CurrentTimeFormat))
+}
diff --git a/mysql/time.go b/mysql/time.go
@@ -34,9 +34,9 @@ var (
 
 // Time format without fractional seconds precision.
 const (
-	DateFormat    = "2006-01-02"
-	CurtimeFormat = "15:04:05"
-	TimeFormat    = "2006-01-02 15:04:05"
+	DateFormat        = "2006-01-02"
+	CurrentTimeFormat = "15:04:05"
+	TimeFormat        = "2006-01-02 15:04:05"
 	// TimeFSPFormat is time format with fractional seconds precision.
 	TimeFSPFormat = "2006-01-02 15:04:05.000000"
 )
@@ -127,7 +127,7 @@ func (t Time) String() string {
 	}
 
 	if t.Type == TypeDuration {
-		return t.Time.Format(CurtimeFormat)
+		return t.Time.Format(CurrentTimeFormat)
 	}
 
 	tfStr := TimeFormat