Skip to content

Commit

Permalink
Use labels in load statements
Browse files Browse the repository at this point in the history
This will fix some issue with loading skylark rules from @bazel_tools.

Tested with ./compile.sh all and also a project that use pkg_tar from
@bazel_tools (which is broken at HEAD).

--
Change-Id: Iffbb7134ef5fee497890c4d01b85084973d45ad0
Reviewed-on: https://bazel-review.googlesource.com/2800
MOS_MIGRATED_REVID=113508661
  • Loading branch information
damienmg committed Feb 2, 2016
1 parent 038a574 commit 68d0b69
Show file tree
Hide file tree
Showing 34 changed files with 37 additions and 37 deletions.
2 changes: 1 addition & 1 deletion BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,6 @@ filegroup(
visibility = ["//visibility:public"],
)

load("/tools/build_rules/go/def", "go_prefix")
load("//tools/build_rules/go:def.bzl", "go_prefix")

go_prefix("github.com/bazelbuild/bazel")
2 changes: 1 addition & 1 deletion examples/d/hello_lib/BUILD
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load(
"/tools/build_defs/d/d",
"//tools/build_defs/d:d.bzl",
"d_docs",
"d_library",
"d_source_library",
Expand Down
2 changes: 1 addition & 1 deletion examples/d/hello_world/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_defs/d/d", "d_binary", "d_docs")
load("//tools/build_defs/d:d.bzl", "d_binary", "d_docs")

d_binary(
name = "hello_world",
Expand Down
2 changes: 1 addition & 1 deletion examples/dotnet/example_binary/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_defs/dotnet/csharp", "csharp_binary")
load("//tools/build_defs/dotnet:csharp.bzl", "csharp_binary")

csharp_binary(
name = "hello",
Expand Down
2 changes: 1 addition & 1 deletion examples/dotnet/example_lib/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_defs/dotnet/csharp", "csharp_library")
load("//tools/build_defs/dotnet:csharp.bzl", "csharp_library")

csharp_library(
name = "MyClass",
Expand Down
2 changes: 1 addition & 1 deletion examples/dotnet/example_test/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_defs/dotnet/csharp", "csharp_nunit_test")
load("//tools/build_defs/dotnet:csharp.bzl", "csharp_nunit_test")

csharp_nunit_test(
name = "MyTest",
Expand Down
2 changes: 1 addition & 1 deletion examples/dotnet/example_transitive_lib/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_defs/dotnet/csharp", "csharp_library")
load("//tools/build_defs/dotnet:csharp.bzl", "csharp_library")

csharp_library(
name = "TransitiveClass",
Expand Down
2 changes: 1 addition & 1 deletion examples/go/bin/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package(
default_visibility = ["//visibility:public"],
)

load("/tools/build_rules/go/def", "go_binary")
load("//tools/build_rules/go:def.bzl", "go_binary")

go_binary(
name = "bin",
Expand Down
2 changes: 1 addition & 1 deletion examples/go/lib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package(
default_visibility = ["//visibility:public"],
)

load("/tools/build_rules/go/def", "go_library", "go_test")
load("//tools/build_rules/go:def.bzl", "go_library", "go_test")

go_library(
name = "go_default_library",
Expand Down
2 changes: 1 addition & 1 deletion examples/go/vendor/github_com/user/vendored/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ package(
default_visibility = ["//visibility:public"],
)

load("/tools/build_rules/go/def", "go_library")
load("//tools/build_rules/go:def.bzl", "go_library")

go_library(
name = "go_default_library",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_rules/java_rules_skylark", "java_library", "java_binary", "java_test")
load("//tools:build_rules/java_rules_skylark.bzl", "java_library", "java_binary", "java_test")

package(default_visibility = ["//visibility:public"])

Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_rules/java_rules_skylark", "java_library", "java_test")
load("//tools:build_rules/java_rules_skylark.bzl", "java_library", "java_test")

java_library(
name = "junit4",
Expand Down
2 changes: 1 addition & 1 deletion examples/jsonnet/BUILD
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load(
"/tools/build_defs/jsonnet/jsonnet",
"//tools/build_defs/jsonnet:jsonnet.bzl",
"jsonnet_library",
"jsonnet_to_json",
"jsonnet_to_json_test",
Expand Down
2 changes: 1 addition & 1 deletion examples/proto/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/genproto", "proto_java_library")
load("//tools:build_rules/genproto.bzl", "proto_java_library")

proto_library(
name = "proto_smoke_test",
Expand Down
2 changes: 1 addition & 1 deletion examples/py/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/py_rules", "py_library", "py_binary")
load("//tools:build_rules/py_rules.bzl", "py_library", "py_binary")

py_library(
name = "lib",
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/fibonacci/BUILD
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load(
"/tools/build_rules/rust/rust",
"//tools/build_rules/rust:rust.bzl",
"rust_library",
"rust_test",
"rust_bench_test",
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/hello_lib/BUILD
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package(default_visibility = ["//visibility:public"])

load(
"/tools/build_rules/rust/rust",
"//tools/build_rules/rust:rust.bzl",
"rust_library",
"rust_test",
"rust_doc",
Expand Down
2 changes: 1 addition & 1 deletion examples/rust/hello_world/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/rust/rust", "rust_binary", "rust_doc", "rust_doc_test")
load("//tools/build_rules/rust:rust.bzl", "rust_binary", "rust_doc", "rust_doc_test")

rust_binary(
name = "hello_world",
Expand Down
2 changes: 1 addition & 1 deletion examples/sass/hello_world/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_defs/sass/sass", "sass_binary")
load("//tools/build_defs/sass:sass.bzl", "sass_binary")

# Import our shared colors and fonts so we can generate a CSS file.
sass_binary(
Expand Down
2 changes: 1 addition & 1 deletion examples/sass/shared/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_defs/sass/sass", "sass_library")
load("//tools/build_defs/sass:sass.bzl", "sass_library")

# make a :colors target that any sass_binary rules can depend on.
sass_library(
Expand Down
4 changes: 2 additions & 2 deletions scripts/packages/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ genrule(
cmd = "cp $< $@",
)

load("self_extract_binary", "self_extract_binary")
load(":self_extract_binary.bzl", "self_extract_binary")

self_extract_binary(
name = "install.sh",
Expand All @@ -57,7 +57,7 @@ self_extract_binary(
],
)

load("/tools/build_defs/pkg/pkg", "pkg_tar", "pkg_deb")
load("//tools/build_defs/pkg:pkg.bzl", "pkg_tar", "pkg_deb")

pkg_tar(
name = "bazel-bin",
Expand Down
2 changes: 1 addition & 1 deletion src/java_tools/buildjar/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ java_test(
#
# Bootstrapping using Skylark rules
#
load("/tools/build_rules/java_rules_skylark", "bootstrap_java_library", "bootstrap_java_binary")
load("//tools:build_rules/java_rules_skylark.bzl", "bootstrap_java_library", "bootstrap_java_binary")

bootstrap_java_library(
name = "skylark-deps",
Expand Down
2 changes: 1 addition & 1 deletion src/java_tools/singlejar/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ java_test(
#
# Bootstrapping using Skylark rules
#
load("/tools/build_rules/java_rules_skylark", "bootstrap_java_library", "bootstrap_java_binary")
load("//tools:build_rules/java_rules_skylark.bzl", "bootstrap_java_library", "bootstrap_java_binary")

bootstrap_java_library(
name = "skylark-deps",
Expand Down
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -919,7 +919,7 @@ genrule(

# Bootstrapping SingleJar using Skylark rules
#
load("/tools/build_rules/java_rules_skylark", "bootstrap_java_library")
load("//tools:build_rules/java_rules_skylark.bzl", "bootstrap_java_library")

bootstrap_java_library(
name = "shell-skylark",
Expand Down
2 changes: 1 addition & 1 deletion src/main/protobuf/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/genproto", "proto_java_library")
load("//tools:build_rules/genproto.bzl", "proto_java_library")

FILES = [
"build",
Expand Down
2 changes: 1 addition & 1 deletion tools/build_defs/docker/testdata/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ package(
],
)

load("/tools/build_defs/docker/docker", "docker_build")
load("//tools/build_defs/docker:docker.bzl", "docker_build")

filegroup(
name = "srcs",
Expand Down
2 changes: 1 addition & 1 deletion tools/build_defs/pkg/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ py_binary(
)

# tests
load("/tools/build_defs/pkg/pkg", "pkg_deb", "pkg_tar")
load("//tools/build_defs/pkg:pkg.bzl", "pkg_deb", "pkg_tar")

genrule(
name = "generate_files",
Expand Down
2 changes: 1 addition & 1 deletion tools/build_defs/sass/test/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
load("sass_rule_test", "sass_rule_test")
load(":sass_rule_test.bzl", "sass_rule_test")

sass_rule_test("//examples/sass")
4 changes: 2 additions & 2 deletions tools/build_defs/sass/test/sass_rule_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
# limitations under the License.

load(
"/tools/build_defs/sass/sass",
"//tools/build_defs/sass:sass.bzl",
"sass_binary",
)

load(
"/tools/build_rules/test_rules",
"//tools:build_rules/test_rules.bzl",
"success_target",
"successful_test",
"failure_target",
Expand Down
2 changes: 1 addition & 1 deletion tools/build_defs/scala/test/BUILD
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
load("/tools/build_defs/scala/scala", "scala_binary", "scala_library")
load("//tools/build_defs/scala:scala.bzl", "scala_binary", "scala_library")

# The examples below show how to combine Scala and Java rules.
# ScalaBinary is the Scala equivalent of JavaBinary.
Expand Down
2 changes: 1 addition & 1 deletion tools/build_rules/go/tools/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/go/def", "go_binary")
load("//tools/build_rules/go:def.bzl", "go_binary")

# This binary is used implicitly by go_test().
go_binary(
Expand Down
2 changes: 1 addition & 1 deletion tools/build_rules/go/tools/filter_tags/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
package(default_visibility = ["//visibility:public"])

load("/tools/build_rules/go/def", "go_prefix", "go_library", "go_binary", "go_test")
load("//tools/build_rules/go:def.bzl", "go_prefix", "go_library", "go_binary", "go_test")

go_library(
name = "filter_tags_lib",
Expand Down
2 changes: 1 addition & 1 deletion tools/build_rules/rust/test/BUILD
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
load("rust_rule_test", "rust_rule_test")
load(":rust_rule_test.bzl", "rust_rule_test")

rust_rule_test("//examples/rust")
4 changes: 2 additions & 2 deletions tools/build_rules/rust/test/rust_rule_test.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,14 @@
"""Tests for rust rules."""

load(
"/tools/build_rules/rust/rust",
"//tools/build_rules/rust:rust.bzl",
"rust_library",
"rust_binary",
"rust_test",
)

load(
"/tools/build_rules/test_rules",
"//tools:build_rules/test_rules.bzl",
"success_target",
"successful_test",
"failure_target",
Expand Down

0 comments on commit 68d0b69

Please sign in to comment.