forked from GetStream/stream-chat-react
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: add guideline how deprecations shall be handled (GetStream#1676)
- Loading branch information
Showing
3 changed files
with
48 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,23 @@ | ||
module.exports = { | ||
extends: ['@commitlint/config-conventional'] | ||
extends: ['@commitlint/config-conventional'], | ||
rules: { | ||
'type-enum': [ | ||
2, | ||
'always', | ||
[ | ||
'build', | ||
'chore', | ||
'ci', | ||
'docs', | ||
'feat', | ||
'fix', | ||
'perf', | ||
'refactor', | ||
'revert', | ||
'style', | ||
'test', | ||
'deprecate', | ||
], | ||
], | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
## Deprecations | ||
|
||
You can deprecate a feature or a component once: | ||
1. an alternative exists. | ||
2. the support for the given functionality is scheduled for termination | ||
|
||
The deprecated component should be marked as follows: | ||
|
||
```typescript jsx | ||
/** | ||
* @deprecated - This UI component will be removed in the next major release. This component is deprecated because <XY>. | ||
* For more information see [docs link](https://....) | ||
* | ||
* FixedHeightMessage - This component renders a single message. | ||
* It uses fixed height elements to make sure it works well in VirtualizedMessageList | ||
*/ | ||
``` | ||
|
||
### How to deprecate? | ||
|
||
1. Deprecated component: | ||
1. does not receive an alternative -> update the documentation on how to implement the deprecated feature. | ||
2. receives an alternative -> update the documentation on how to use the introduced alternative solution. | ||
2. Commit the changes under `deprecate` commit type, with commit description stating the reasons for deprecation. | ||
3. Create an issue, so it can be scheduled for removal in foreseeable future. Tag the issue with the label `breaking`. |