Creating run backfill #46348
Merged
Creating run backfill #46348
+544
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbovenzi
requested changes
Feb 1, 2025
There was a problem hiding this comment.
Thanks for taking this on!
We need to change the fields from DagRun Trigger to Backfill. Here are the fields we need to have:
export type BackfillPostBody = {
dag_id: string;
from_date: string;
to_date: string;
run_backwards?: boolean;
dag_run_conf?: {
[key: string]: unknown;
};
reprocess_behavior?: "failed" | "completed" | "none";
max_active_runs?: number;
};
Starting to call the APIs still has some issues
|
Still needs some fixing up, throws a bunch of errors on sending the requests. Pushing now to get some feedback on the UI changes. |
This is what the UI looks like right now.
|
bbovenzi
reviewed
Feb 11, 2025
bbovenzi
reviewed
Feb 11, 2025
bbovenzi
reviewed
Feb 11, 2025
Looking better. A few notes:
|
Added an alert for number of backfills, fixed the dryrun request, fixed up a bit of the UI.
Latest UI
|
aritra24
requested review from
pierrejeambrun,
ryanahamilton and
jscheffl
as code owners
bbovenzi
reviewed
Feb 12, 2025
bbovenzi
approved these changes
Feb 12, 2025
|
Thanks for all the feedback! |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
* WIP: Creating run backfill * ui changes, some temp code to be filled in * Fixing up a bunch of UI Starting to call the APIs still has some issues * remove null note in ActionAccordion * Updated UI Added an alert for number of backfills, fixed the dryrun request, fixed up a bit of the UI. * Resolved review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #43969
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.