Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIP-82 Introduce BaseEventTrigger as base class for triggers used with event driven scheduling #46391

Merged
merged 7 commits into from
Feb 13, 2025

Conversation

vincbeck
Copy link
Contributor

@vincbeck vincbeck commented Feb 3, 2025

As explained in the lazy consensus thread, we need to create a new base class BaseEventTrigger. This new base class allows categorizing triggers suitable for event driven scheduling usage. Not all triggers should be used to schedule DAGs, BaseEventTrigger is making this categorization.


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@vincbeck vincbeck requested a review from ashb February 3, 2025 17:51
@vincbeck vincbeck force-pushed the vincbeck/base_event_trigger branch 3 times, most recently from 823cf8f to 9747cfe Compare February 4, 2025 16:04
@vincbeck vincbeck removed the provider:amazon AWS/Amazon - related issues label Feb 4, 2025
@vincbeck vincbeck force-pushed the vincbeck/base_event_trigger branch from 9747cfe to 0c063ba Compare February 4, 2025 17:10
@vincbeck vincbeck force-pushed the vincbeck/base_event_trigger branch from 0c063ba to 3272a88 Compare February 4, 2025 18:28
@vincbeck vincbeck force-pushed the vincbeck/base_event_trigger branch from c9a4a30 to 7df99de Compare February 6, 2025 18:15
@vincbeck vincbeck force-pushed the vincbeck/base_event_trigger branch from 7df99de to 174aa87 Compare February 6, 2025 19:43
@Lee-W Lee-W self-requested a review February 7, 2025 02:40
@vincbeck
Copy link
Contributor Author

Anyone? @ashb @Lee-W ?

Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no major issue on my end. looks good. left a few nitpicks

airflow/example_dags/example_asset_with_watchers.py Outdated Show resolved Hide resolved
airflow/triggers/base.py Outdated Show resolved Hide resolved
Copy link
Member

@Lee-W Lee-W left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vincbeck vincbeck merged commit 3ad8787 into apache:main Feb 13, 2025
63 checks passed
@vincbeck vincbeck deleted the vincbeck/base_event_trigger branch February 13, 2025 14:50
ambika-garg pushed a commit to ambika-garg/airflow that referenced this pull request Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants